From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A929CC433F5 for ; Mon, 8 Nov 2021 23:41:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FA11611BF for ; Mon, 8 Nov 2021 23:41:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238600AbhKHXol (ORCPT ); Mon, 8 Nov 2021 18:44:41 -0500 Received: from gw2.atmark-techno.com ([35.74.137.57]:52458 "EHLO gw2.atmark-techno.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231268AbhKHXok (ORCPT ); Mon, 8 Nov 2021 18:44:40 -0500 Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by gw2.atmark-techno.com (Postfix) with ESMTPS id 203C920D48 for ; Tue, 9 Nov 2021 08:41:54 +0900 (JST) Received: by mail-pg1-f198.google.com with SMTP id w13-20020a63934d000000b002a2935891daso10913858pgm.15 for ; Mon, 08 Nov 2021 15:41:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9JYAOHc5Bzc8zfpQ0inqY9Jus/ttd4RsPfwt3JJBGgs=; b=73d5cjtgkzOH2NW3HW4zhGExclV9kXlVzD26Wf+FS2Mh4p2aEvEpCf8R4eZvdDVt2t T+c4wVbxihnMdwzTl+aH3yxCj7wHn9OVeZJxNk3rFne/YaaVB5tJJ1l5PPfnBqp1ZWf3 Q+TQN1Ln56fijJwpo+DflmlZ/qJt6KcGut4zvfpDXZ/0tOFzMyUbofJFd0wi3G07xXlc LX4G0nPNqx0QqQgeh6nLWBjBM2f0HuiakndQx0vuAOh4bd7UUfKPi+qyJmB7y8mC8098 QYG+qQQGqMDvDHbKhQA06NuAtjxEQ5nCMgeE6o08EQragSa48prljC7LM2I4OPVfKbT3 MsRA== X-Gm-Message-State: AOAM530RDsvMmNMv881VY/Qwl8wolut7GItpk9AWSskisly/IyDPGFPI RNga2i5ovMrFr1NnWGdnVae1WbcFKbv9N1IHcHef/y30bfpV2cGw1/HezAX2nF+W+WT+YHFoPJj xuh+BfOf+5dQIX45EfFGfMQ== X-Received: by 2002:a63:b54a:: with SMTP id u10mr2498358pgo.69.1636414913169; Mon, 08 Nov 2021 15:41:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwGtJSPNlUIj77nNviXLhyTvTLyu/pChs/rPD9a5gR5EudQZYF25eTXL+L5gjHwbBFkWtMLew== X-Received: by 2002:a63:b54a:: with SMTP id u10mr2498335pgo.69.1636414912929; Mon, 08 Nov 2021 15:41:52 -0800 (PST) Received: from pc-0115 (162.198.187.35.bc.googleusercontent.com. [35.187.198.162]) by smtp.gmail.com with ESMTPSA id e14sm13407047pga.76.2021.11.08.15.41.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Nov 2021 15:41:52 -0800 (PST) Received: from martinet by pc-0115 with local (Exim 4.94.2) (envelope-from ) id 1mkEGt-0065Az-2P; Tue, 09 Nov 2021 08:41:51 +0900 Date: Tue, 9 Nov 2021 08:41:41 +0900 From: Dominique Martinet To: Alexandre Belloni Cc: Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] rtc-rv8803: fix writing back ctrl in flag register Message-ID: References: <20211101013400.325855-1-dominique.martinet@atmark-techno.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Alexandre Belloni wrote on Mon, Nov 08, 2021 at 09:42:53AM +0100: > On 08/11/2021 12:16:59+0900, Dominique Martinet wrote: > > Hi Alexandre, Alessandro, > > > > the other patch was proved to be unneeded, but this one is still a valid > > fix as far as I can understand the code (reusing RV8803_CTRL value to > > write into RV8803_FLAG does not look correct) > > > > (I'm also convinced either mostly work because the original values are > > usually close enough, but that's not a reason to keep using the wrong > > one) > > > > > > Would you have time to take a look? > > I did check with the initial review and I'm going to apply it, I just > didn't have the time to do that yet. Sorry, it wasn't clear to me whether this was dropped with the other or not. There's no hurry on my end, please apply when you can! Thanks, -- Dominique