From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28420C43334 for ; Fri, 10 Jun 2022 12:04:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245605AbiFJMEG (ORCPT ); Fri, 10 Jun 2022 08:04:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241046AbiFJMEF (ORCPT ); Fri, 10 Jun 2022 08:04:05 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 174AE36E1C; Fri, 10 Jun 2022 05:04:01 -0700 (PDT) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 2142C60008; Fri, 10 Jun 2022 12:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654862639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wk/jtq8xnieuXpnFHV28FbZhaagmc7D9cxAaLwaoz9Y=; b=CYs4u8lBEb8T+7VflaieA4F8cQQ+Wv8XFP5a/KeI75L8Lulgv/WMPFpaLVkcv17QBvKyhg 03amMT0xX+/StH3JDr4WY276TWhEPhsQT4TRU7UjBxh7qaUx9++aDUv0KPSd5xYZ8em+Ks k/oujVqIwLA/wMQBb4YBQr701dNHLLcG51tvgbmXG9tm+w6FrBVd6/dUn2zE7dw13jewa4 XMZT9wL3Nr9GZskUdAYx3YNJxcEFeVmj1asPRMnHBMIxE0sXPKcXancUaxGpUmr3JEc7P+ CkarAIjFkWTwuxglW+tKo2Hcy2ViMfe8J8/w00sWGiCjg7a2/XrvCLsb8ek1bw== Date: Fri, 10 Jun 2022 14:03:55 +0200 From: Alexandre Belloni To: Srinivas Neeli Cc: a.zummo@towertech.it, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com, sgoud@xilinx.com, shubhraj@xilinx.com, srinivas.neeli@amd.com, neelisrinivas18@gmail.com, devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, git@xilinx.com Subject: Re: [PATCH V7 3/3] rtc: zynqmp: Updated calibration value Message-ID: References: <20220610113709.2646118-1-srinivas.neeli@xilinx.com> <20220610113709.2646118-3-srinivas.neeli@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220610113709.2646118-3-srinivas.neeli@xilinx.com> Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 10/06/2022 17:07:09+0530, Srinivas Neeli wrote: > As per RTC spec default calibration value is 0x7FFF. > Having that as a second patch breaks the calculation in your previous patch, really, this should just be a single patch. > Signed-off-by: Srinivas Neeli > --- > Changes in V7: > -New patch > -TRM not updated yet, Internal design document contains 0x7FFF as > default value. TRM Will update in next release. > --- > drivers/rtc/rtc-zynqmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c > index 39b23f88ee26..1dd389b891fe 100644 > --- a/drivers/rtc/rtc-zynqmp.c > +++ b/drivers/rtc/rtc-zynqmp.c > @@ -37,7 +37,7 @@ > #define RTC_OSC_EN BIT(24) > #define RTC_BATT_EN BIT(31) > > -#define RTC_CALIB_DEF 0x198233 > +#define RTC_CALIB_DEF 0x7FFF > #define RTC_CALIB_MASK 0x1FFFFF > #define RTC_ALRM_MASK BIT(1) > #define RTC_MSEC 1000 > -- > 2.25.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com