Re: [PATCH 2/2] dt-bindings: rtc: Add EM Microelectronic EM3027 bindings

Alexandre Belloni
2021-12-17T17:07:37Z

Hello,

On 17/12/2021 18:03:11+0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Document the bindings for the EM Microelectronic EM3027 RTC.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../bindings/rtc/emmicro,em3027.yaml | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/emmicro,em3027.yaml
>
> diff --git a/Documentation/devicetree/bindings/rtc/emmicro,em3027.yaml b/Documentation/devicetree/bindings/rtc/emmicro,em3027.yaml
> new file mode 100644
> index 000000000000..abed14c4fcd5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/emmicro,em3027.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/emmicro,em3027.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: EM Microelectronic EM3027 RTC Device Tree Bindings
> +
> +maintainers:
> + - Alexandre Belloni <alexandre.belloni@bootlin.com>
> +
> +properties:
> + compatible:
> + const: emmicro,em3027
> +
> + reg:
> + maxItems: 1
> +
> +allOf:
> + - $ref: "rtc.yaml#"
> +
> +additionalProperties: false
> +

If there are no further properties, maybe trivial-rtc.yaml?

> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rtc@56 {
> + compatible = "emmicro,em3027";
> + reg = <0x56>;
> + };
> + };
> --
> 2.34.1
>

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering