public inbox for linux-rtc@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: rtc: isl12026: convert to YAML schema
@ 2026-02-18 19:02 Piyush Patle
  2026-02-18 19:20 ` Krzysztof Kozlowski
  2026-02-18 20:27 ` Rob Herring (Arm)
  0 siblings, 2 replies; 3+ messages in thread
From: Piyush Patle @ 2026-02-18 19:02 UTC (permalink / raw)
  To: alexandre.belloni
  Cc: robh, krzk+dt, conor+dt, linux-rtc, devicetree, linux-kernel

Convert the ISL12026 RTC binding to DT schema format.

The binding was previously documented in text format.
This converts it to YAML and enables dtbs_check validation.

Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
---
 .../bindings/rtc/isil,isl12026.yaml           | 57 +++++++++++++++++++
 1 file changed, 57 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/isil,isl12026.yaml

diff --git a/Documentation/devicetree/bindings/rtc/isil,isl12026.yaml b/Documentation/devicetree/bindings/rtc/isil,isl12026.yaml
new file mode 100644
index 000000000000..5f0ac73b1fde
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/isil,isl12026.yaml
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/rtc/isil,isl12026.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Intersil ISL12026 I2C RTC/EEPROM
+
+maintainers:
+  - Piyush Patle piyushpatle228@gmail.com
+
+description: |
+  The ISL12026 is a combination RTC and EEPROM device connected via I2C.
+  The RTC and control registers respond at address 0x6f, while the EEPROM
+  array responds at address 0x57. The "reg" property refers to the RTC
+  portion of the device.
+
+allOf:
+  - $ref: rtc.yaml#
+
+properties:
+  compatible:
+    const: isil,isl12026
+
+  reg:
+    maxItems: 1
+    description: I2C address of the RTC portion (must be 0x6f)
+
+  isil,pwr-bsw:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Value written to the PWR.BSW bit for proper device operation.
+
+  isil,pwr-sbib:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Value written to the PWR.SBIB bit for proper device operation.
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        rtc@6f {
+            compatible = "isil,isl12026";
+            reg = <0x6f>;
+            isil,pwr-bsw = <0>;
+            isil,pwr-sbib = <1>;
+        };
+    };
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: rtc: isl12026: convert to YAML schema
  2026-02-18 19:02 [PATCH] dt-bindings: rtc: isl12026: convert to YAML schema Piyush Patle
@ 2026-02-18 19:20 ` Krzysztof Kozlowski
  2026-02-18 20:27 ` Rob Herring (Arm)
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-18 19:20 UTC (permalink / raw)
  To: Piyush Patle, alexandre.belloni
  Cc: robh, krzk+dt, conor+dt, linux-rtc, devicetree, linux-kernel

On 18/02/2026 20:02, Piyush Patle wrote:
> Convert the ISL12026 RTC binding to DT schema format.
> 
> The binding was previously documented in text format.
> This converts it to YAML and enables dtbs_check validation.

You already said it in the first sentence.

> 
> Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
> ---
>  .../bindings/rtc/isil,isl12026.yaml           | 57 +++++++++++++++++++

Where is the conversion?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: rtc: isl12026: convert to YAML schema
  2026-02-18 19:02 [PATCH] dt-bindings: rtc: isl12026: convert to YAML schema Piyush Patle
  2026-02-18 19:20 ` Krzysztof Kozlowski
@ 2026-02-18 20:27 ` Rob Herring (Arm)
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2026-02-18 20:27 UTC (permalink / raw)
  To: Piyush Patle
  Cc: krzk+dt, linux-rtc, devicetree, conor+dt, linux-kernel,
	alexandre.belloni


On Thu, 19 Feb 2026 00:32:13 +0530, Piyush Patle wrote:
> Convert the ISL12026 RTC binding to DT schema format.
> 
> The binding was previously documented in text format.
> This converts it to YAML and enables dtbs_check validation.
> 
> Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
> ---
>  .../bindings/rtc/isil,isl12026.yaml           | 57 +++++++++++++++++++
>  1 file changed, 57 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/isil,isl12026.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/rtc/isil,isl12026.yaml:4:6: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/rtc/isil,isl12026.yaml:5:10: [error] string value is redundantly quoted with any quotes (quoted-strings)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/isil,isl12026.yaml: maintainers:0: 'Piyush Patle piyushpatle228@gmail.com' does not match '^(.+ <[\\S]+@[\\S]+>|[\\S]+@[\\S]+)$'
	from schema $id: http://devicetree.org/meta-schemas/base.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260218190213.429892-1-piyushpatle228@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-18 20:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-18 19:02 [PATCH] dt-bindings: rtc: isl12026: convert to YAML schema Piyush Patle
2026-02-18 19:20 ` Krzysztof Kozlowski
2026-02-18 20:27 ` Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox