Re: [PATCH 6/6] i2c: Make remove callback return void

Uwe Kleine-König
2022-06-29T07:24:15Z

[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]

Hello,

[I dropped nearly all individuals from the Cc: list because various
bounces reported to be unhappy about the long (logical) line.]

On Wed, Jun 29, 2022 at 03:03:54PM +0800, Jeremy Kerr wrote:
> Looks good - just one minor change for the mctp-i2c driver, but only
> worthwhile if you end up re-rolling this series for other reasons:
>
> > -static int mctp_i2c_remove(struct i2c_client *client)
> > +static void mctp_i2c_remove(struct i2c_client *client)
> >  {
> >         struct mctp_i2c_client *mcli = i2c_get_clientdata(client);
> >         struct mctp_i2c_dev *midev = NULL, *tmp = NULL;
> > @@ -1000,7 +1000,6 @@ static int mctp_i2c_remove(struct i2c_client *client)
> >         mctp_i2c_free_client(mcli);
> >         mutex_unlock(&driver_clients_lock);
> >         /* Callers ignore return code */
> > -       return 0;
> >  }
>
> The comment there no longer makes much sense, I'd suggest removing that
> too.

Yeah, that was already pointed out to me in a private reply. It's
already fixed in

https://git.pengutronix.de/cgit/ukl/linux/log/?h=i2c-remove-void

> Either way:
>
> Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au>

Added to my tree, too.

Thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]