From: "Nuno Sá" <noname.nuno@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Antoniu Miclaus <antoniu.miclaus@analog.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH] rtc: max31335: use correct CONFIG symbol in IS_REACHABLE()
Date: Mon, 12 Jan 2026 13:23:03 +0000 [thread overview]
Message-ID: <a9a59334e29ecf10ed8e6d737e5b918580446a69.camel@gmail.com> (raw)
In-Reply-To: <20260108045432.2705691-1-rdunlap@infradead.org>
On Wed, 2026-01-07 at 20:54 -0800, Randy Dunlap wrote:
> IS_REACHABLE() is meant to be used with full symbol names from a kernel
> .config file, not the shortened symbols used in Kconfig files, so
> change HWMON to CONFIG_HWMON in 3 places.
>
> Fixes: dedaf03b99d6 ("rtc: max31335: add driver support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
Acked-by: Nuno Sá <nuno.sa@analog.com>
> Cc: Antoniu Miclaus <antoniu.miclaus@analog.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: linux-rtc@vger.kernel.org
>
> drivers/rtc/rtc-max31335.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- linux-next-20260107.orig/drivers/rtc/rtc-max31335.c
> +++ linux-next-20260107/drivers/rtc/rtc-max31335.c
> @@ -591,7 +591,7 @@ static struct nvmem_config max31335_nvme
> .size = MAX31335_RAM_SIZE,
> };
>
> -#if IS_REACHABLE(HWMON)
> +#if IS_REACHABLE(CONFIG_HWMON)
> static int max31335_read_temp(struct device *dev, enum hwmon_sensor_types type,
> u32 attr, int channel, long *val)
> {
> @@ -672,7 +672,7 @@ static int max31335_clkout_register(stru
> static int max31335_probe(struct i2c_client *client)
> {
> struct max31335_data *max31335;
> -#if IS_REACHABLE(HWMON)
> +#if IS_REACHABLE(CONFIG_HWMON)
> struct device *hwmon;
> #endif
> const struct chip_desc *match;
> @@ -727,7 +727,7 @@ static int max31335_probe(struct i2c_cli
> return dev_err_probe(&client->dev, ret,
> "cannot register rtc nvmem\n");
>
> -#if IS_REACHABLE(HWMON)
> +#if IS_REACHABLE(CONFIG_HWMON)
> if (max31335->chip->temp_reg) {
> hwmon = devm_hwmon_device_register_with_info(&client->dev, client->name,
> max31335,
> &max31335_chip_info, NULL);
next prev parent reply other threads:[~2026-01-12 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 4:54 [PATCH] rtc: max31335: use correct CONFIG symbol in IS_REACHABLE() Randy Dunlap
2026-01-12 13:23 ` Nuno Sá [this message]
2026-01-19 23:17 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9a59334e29ecf10ed8e6d737e5b918580446a69.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=antoniu.miclaus@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox