From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBED3C04EB8 for ; Thu, 6 Dec 2018 07:22:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7475E20989 for ; Thu, 6 Dec 2018 07:22:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="XPikO0kd"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="oj0XVGeA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7475E20989 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rtc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728842AbeLFHW5 (ORCPT ); Thu, 6 Dec 2018 02:22:57 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35294 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728758AbeLFHW4 (ORCPT ); Thu, 6 Dec 2018 02:22:56 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E602C601C4; Thu, 6 Dec 2018 07:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1544080976; bh=wz6qGcHWlFJDR0F7KbH9E1mxunYOg4RWT/B/5CAuHBs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XPikO0kdgLwJe2SYlN9IE0d6Lw5uaVByNwR1rkrJyqbOGjBAT2xuvBl2/NoYgrrpR sf6unXYnQpesc2ROWSeOgYe5/pEQFtY8B/XtrIxtzcmLFhetRJkZv2fo6RCwZj0w3W bE1IeSP0M7hfYHex5Or1JVQ/bWAO6LSeAlwJBrUE= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 285E86028B; Thu, 6 Dec 2018 07:22:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1544080971; bh=wz6qGcHWlFJDR0F7KbH9E1mxunYOg4RWT/B/5CAuHBs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oj0XVGeAnbHD9Kcl0UUiboOopq1cQ9kUZ3/ya1c2B+yOU3ZEqsvnETGkurKEypNs9 Dkbj3jJv36qaKBgT8BIdMa/ZYoL7acM7C/SKV0xGD/41lXdJvbcrAddWg+Yuo0HMON 78OPXxvutkATFBAAty9GbZrVfiyPagYZWCe8gU40= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 06 Dec 2018 15:22:51 +0800 From: yuankuiz@codeaurora.org To: a.zummo@towertech.it, alexandre.belloni@bootlin.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc-owner@vger.kernel.org Subject: Re: [PATCH] rtc: proc: printf using alarm for alrm In-Reply-To: References: Message-ID: X-Sender: yuankuiz@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Hi, Kindly, this format change formats the rtc dump from: alrm_time : 00:00:00 alrm_date : 1970-01-01 alarm_IRQ : no alrm_pending : no to: alarm time : 00:00:00 alarm date : 1970-01-01 alarm IRQ : no alarm pending : no Thanks, BR//John Zhao On 2018-12-04 05:29 PM, yuankuiz@codeaurora.org wrote: > Hi, > > From 549bae59445c5ec67dd6a46f3ea4f58966d40c9b > > Current the struct rtc_wkalrm is dumped as > "alrm_" by printing converted from the struct > name of "alrm.*" directly. Shall we use the > "alarm *" to replace the "alrm_*" during this > dumping? > > Signed-off-by: John Zhao > --- > drivers/rtc/rtc-proc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/rtc/rtc-proc.c b/drivers/rtc/rtc-proc.c > index a9dd921..d4a3c91 100644 > --- a/drivers/rtc/rtc-proc.c > +++ b/drivers/rtc/rtc-proc.c > @@ -58,7 +58,7 @@ static int rtc_proc_show(struct seq_file *seq, void > *offset) > > err = rtc_read_alarm(rtc, &alrm); > if (err == 0) { > - seq_printf(seq, "alrm_time\t: "); > + seq_printf(seq, "alarm time\t: "); > if ((unsigned int)alrm.time.tm_hour <= 24) > seq_printf(seq, "%02d:", alrm.time.tm_hour); > else > @@ -72,7 +72,7 @@ static int rtc_proc_show(struct seq_file *seq, void > *offset) > else > seq_printf(seq, "**\n"); > > - seq_printf(seq, "alrm_date\t: "); > + seq_printf(seq, "alarm date\t: "); > if ((unsigned int)alrm.time.tm_year <= 200) > seq_printf(seq, "%04d-", alrm.time.tm_year + 1900); > else > @@ -85,9 +85,9 @@ static int rtc_proc_show(struct seq_file *seq, void > *offset) > seq_printf(seq, "%02d\n", alrm.time.tm_mday); > else > seq_printf(seq, "**\n"); > - seq_printf(seq, "alarm_IRQ\t: %s\n", > + seq_printf(seq, "alarm IRQ\t: %s\n", > alrm.enabled ? "yes" : "no"); > - seq_printf(seq, "alrm_pending\t: %s\n", > + seq_printf(seq, "alarm pending\t: %s\n", > alrm.pending ? "yes" : "no"); > seq_printf(seq, "update IRQ enabled\t: %s\n", > (rtc->uie_rtctimer.enabled) ? "yes" : "no");