From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: rtc: qcom-pm8xxx: fix inconsistent example
Date: Fri, 1 Dec 2023 09:32:46 +0100 [thread overview]
Message-ID: <ad96b95a-5f4f-4333-b767-762936932061@linaro.org> (raw)
In-Reply-To: <20231130173223.12794-1-johan+linaro@kernel.org>
On 30/11/2023 18:32, Johan Hovold wrote:
> The PM8921 is an SSBI PMIC but in the binding example it is described
> as being part of an SPMI PMIC while using an SSBI address.
>
> Make the example consistent by using the sibling PM8941 SPMI PMIC
> instead.
>
> Fixes: 8138c5f0318c ("dt-bindings: rtc: qcom-pm8xxx-rtc: Add qcom pm8xxx rtc bindings")
Similarly to your thermal patch - this is just an example, not a
binding. No bugs are fixed here, no need for backports.
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> .../bindings/rtc/qcom-pm8xxx-rtc.yaml | 36 +++++++++----------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-01 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 17:32 [PATCH] dt-bindings: rtc: qcom-pm8xxx: fix inconsistent example Johan Hovold
2023-12-01 8:32 ` Krzysztof Kozlowski [this message]
2023-12-01 9:31 ` Johan Hovold
2023-12-01 16:27 ` Conor Dooley
2023-12-01 16:37 ` Johan Hovold
2023-12-19 15:57 ` Johan Hovold
2024-01-08 0:32 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad96b95a-5f4f-4333-b767-762936932061@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox