From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE1F2ECAAD3 for ; Thu, 15 Sep 2022 06:54:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229463AbiIOGyn (ORCPT ); Thu, 15 Sep 2022 02:54:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbiIOGyn (ORCPT ); Thu, 15 Sep 2022 02:54:43 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8015DDED1; Wed, 14 Sep 2022 23:54:40 -0700 (PDT) Received: from dggpeml500021.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MSnsS0r30zmVNN; Thu, 15 Sep 2022 14:50:52 +0800 (CST) Received: from dggpeml500010.china.huawei.com (7.185.36.155) by dggpeml500021.china.huawei.com (7.185.36.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 15 Sep 2022 14:54:38 +0800 Received: from [10.67.111.232] (10.67.111.232) by dggpeml500010.china.huawei.com (7.185.36.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 15 Sep 2022 14:54:38 +0800 Message-ID: Date: Thu, 15 Sep 2022 14:54:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH -next v2] rtc: stmp3xxx: Add failure handling for stmp3xxx_wdt_register() To: Wolfram Sang , , , , , , , , , , References: <20220915013304.213917-1-linyujun809@huawei.com> From: "linyujun (C)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.111.232] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500010.china.huawei.com (7.185.36.155) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org OK, I'll remove the second part of the commit message and send a v3 patch. 在 2022/9/15 14:31, Wolfram Sang 写道: > On Thu, Sep 15, 2022 at 09:33:04AM +0800, Lin Yujun wrote: >> Use platform_device_put() to free platform device before print >> error message when platform_device_add() fails to run. Add dev_err() >> to report error in case of alloc memory to wdt_pdev fail. > The second part of the commit message is now obsolete. >