From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 576873BD64A; Mon, 20 Jul 2026 09:39:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784540366; cv=none; b=G6sTuK8NvLczUcEVrC1fZa0yJAGTBY2no4lUPbhJqvVv35AASvNsHlBatYGDBfgQlxEJsFBSo7Rqb/eALsfnn6wmowtZ+sA+m6WCrmL9JkG5mW+VMFI+mXtEshqeueZGuhSfikKHayRYSHiHFOJgJ8C6OIBCJTHZvjyS9gtIKzk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784540366; c=relaxed/simple; bh=8yvWTYbYBGZHHcLjIbER34ILyGhNaja8leys0MdkVFQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GRqN56aBbFpcJ1Ly8v1GS3Vst3HkeR2PoRKaSJnosADW+jMKdreJOK4QWzEcn0iH6311RirkfvOcfG+fz4bG7WzZA8UCt+fFgIAYhtZpmV1FmsMj7NlSXTkIEQUPau19cxoWWUHqLxiXrcipAI4KPlLiKeb1kMiPdItLDDx8NoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KTS/WRn4; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KTS/WRn4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784540364; x=1816076364; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8yvWTYbYBGZHHcLjIbER34ILyGhNaja8leys0MdkVFQ=; b=KTS/WRn4hC64SXomcj8OZDgv1c/75sr512hJ3ZZFOcn/Hz2j9Y9jUoL5 F2e+OqhVszGdUTiQ8gFa21IWsAwRL5NL4agOEdBKXNXj2/5XleLx2segL Dk4x4iOBE2N/2Ois/Ww1kLHTyw2za1XN+80oavKfNGr+HKHwjVMBVuWAo ieR3UZ5XBhpm7Zj7akq7FaZFCS9NSIbDOMwrO25uQDKI0WMShkt0G+f9M 25PvW79ouLpjIBPXpFkB88q1yZQVg2V/olRE0dNbotb9btcIBQM1VJEkm ms64R1mv8sTuuOBGo4/IM41QgQy1HQET/Z3FsZmraa/F+L6x5Weqg2HY+ A==; X-CSE-ConnectionGUID: tjOSX/HpTCmrIrOHrf6Qaw== X-CSE-MsgGUID: 1SJcmtt2S4Oxv7DLT2gBxQ== X-IronPort-AV: E=McAfee;i="6800,10657,11851"; a="107904617" X-IronPort-AV: E=Sophos;i="6.25,174,1779174000"; d="scan'208";a="107904617" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2026 02:39:23 -0700 X-CSE-ConnectionGUID: nA9+Vz6sSKmkO0mDbOt0pw== X-CSE-MsgGUID: jJmd9OFtSVWnkAUWymXgRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,174,1779174000"; d="scan'208";a="257477511" Received: from kniemiec-mobl1.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.244.94]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2026 02:39:14 -0700 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 96736121C07; Mon, 20 Jul 2026 12:39:16 +0300 (EEST) Date: Mon, 20 Jul 2026 12:39:16 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Link Mauve Cc: Srinivas Kandagatla , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Tianshu Qiu , Bingbu Cao , Mauro Carvalho Chehab , Aaro Koskinen , Andreas Kemnade , Roger Quadros , Tony Lindgren , Lee Jones , Arnd Bergmann , Greg Kroah-Hartman , Bartosz Golaszewski , "Vaibhaav Ram T.L" , Kumaravel Thiagarajan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vladimir Zapolskiy , =?iso-8859-1?Q?Andr=E9?= Draszik , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Praveen Teja Kundanala , Kalyani Akula , Michal Simek , Alexandre Belloni , Joshua Kinard , Antoniu Miclaus , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Miguel Ojeda , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , Onur =?iso-8859-1?Q?=D6zkan?= , Daniel Lezcano , Johan Hovold , Ronald Claveau , Salah Triki , Yury Norov , David Carlier , Achim Gratz , Alexander Sverdlin , Patrick Wicki , Markus Heidelberg , Markus Perkins , Uwe =?iso-8859-1?Q?Kleine-K=F6nig_=28The_Capable_Hub=29?= , Bjorn Helgaas , Abd-Alrhman Masalkhi , Chen Ni , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, mfd@lists.linux.dev, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-rtc@vger.kernel.org, linux-sunxi@lists.linux.dev, rust-for-linux@vger.kernel.org Subject: Re: [PATCH 8/8] media: ov2740: remove NULL reg_write callback Message-ID: References: <20260715175229.24672-1-linkmauve@linkmauve.fr> <20260715175229.24672-9-linkmauve@linkmauve.fr> Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260715175229.24672-9-linkmauve@linkmauve.fr> Hi, On Wed, Jul 15, 2026 at 07:52:24PM +0200, Link Mauve wrote: > This field is already initialized to NULL, so there is no reason to > write it again. > > This prevents it from appearing while grepping for reg_write in the > future. > > Signed-off-by: Link Mauve I believe we need a real name here. > --- > drivers/media/i2c/ov2740.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c > index fb590dfadda1..799eca4023da 100644 > --- a/drivers/media/i2c/ov2740.c > +++ b/drivers/media/i2c/ov2740.c > @@ -1271,7 +1271,6 @@ static int ov2740_register_nvmem(struct i2c_client *client, > nvmem_config.compat = true; > nvmem_config.base_dev = dev; > nvmem_config.reg_read = ov2740_nvmem_read; > - nvmem_config.reg_write = NULL; > nvmem_config.priv = nvm; > nvmem_config.stride = 1; > nvmem_config.word_size = 1; I think it'd be nicer to do the initialisation in variable declaration -- all the information is available already there. -- Regards, Sakari Ailus