From: Julia Lawall <julia.lawall@lip6.fr>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
Cc: Miodrag Dinic <miodrag.dinic@imgtec.com>,
Goran Ferenc <goran.ferenc@imgtec.com>,
Aleksandar Markovic <aleksandar.markovic@imgtec.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Bo Hu <bohu@google.com>, "David S. Miller" <davem@davemloft.net>,
Douglas Leung <douglas.leung@imgtec.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Hogan <james.hogan@imgtec.com>,
Jin Qian <jinqian@google.com>,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Paul Burton <paul.burton@imgtec.com>,
Petar Jovanovic <petar.jovanovic@imgtec.com>,
Raghu Gandham <raghu.gandham@imgtec.com>,
linux-mips@linux-mips.org, kbuild-all@01.org
Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver (fwd)
Date: Mon, 24 Jul 2017 06:54:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1707240652320.3169@hadrien> (raw)
Please check line 203; it seems that the tested value is unsigned.
julia
---------- Forwarded message ----------
Date: Mon, 24 Jul 2017 11:40:38 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
Hi Miodrag,
[auto build test WARNING on linus/master]
[also build test WARNING on v4.13-rc2 next-20170721]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Aleksandar-Markovic/MIPS-Add-virtual-Ranchu-board-as-a-generic-based-board/20170724-062318
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
>> drivers/rtc/rtc-goldfish.c:203:5-16: WARNING: Unsigned expression compared with zero: rtcdrv -> irq < 0
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 3b43c4b417a02749f734942456b41eb397e389ae
vim +203 drivers/rtc/rtc-goldfish.c
3b43c4b4 Miodrag Dinic 2017-07-21 181
3b43c4b4 Miodrag Dinic 2017-07-21 182 static int goldfish_rtc_probe(struct platform_device *pdev)
3b43c4b4 Miodrag Dinic 2017-07-21 183 {
3b43c4b4 Miodrag Dinic 2017-07-21 184 struct resource *r;
3b43c4b4 Miodrag Dinic 2017-07-21 185 struct goldfish_rtc *rtcdrv;
3b43c4b4 Miodrag Dinic 2017-07-21 186 int err;
3b43c4b4 Miodrag Dinic 2017-07-21 187
3b43c4b4 Miodrag Dinic 2017-07-21 188 rtcdrv = devm_kzalloc(&pdev->dev, sizeof(*rtcdrv), GFP_KERNEL);
3b43c4b4 Miodrag Dinic 2017-07-21 189 if (rtcdrv == NULL)
3b43c4b4 Miodrag Dinic 2017-07-21 190 return -ENOMEM;
3b43c4b4 Miodrag Dinic 2017-07-21 191
3b43c4b4 Miodrag Dinic 2017-07-21 192 platform_set_drvdata(pdev, rtcdrv);
3b43c4b4 Miodrag Dinic 2017-07-21 193
3b43c4b4 Miodrag Dinic 2017-07-21 194 r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
3b43c4b4 Miodrag Dinic 2017-07-21 195 if (r == NULL)
3b43c4b4 Miodrag Dinic 2017-07-21 196 return -ENODEV;
3b43c4b4 Miodrag Dinic 2017-07-21 197
3b43c4b4 Miodrag Dinic 2017-07-21 198 rtcdrv->base = devm_ioremap_resource(&pdev->dev, r);
3b43c4b4 Miodrag Dinic 2017-07-21 199 if (IS_ERR(rtcdrv->base))
3b43c4b4 Miodrag Dinic 2017-07-21 200 return -ENODEV;
3b43c4b4 Miodrag Dinic 2017-07-21 201
3b43c4b4 Miodrag Dinic 2017-07-21 202 rtcdrv->irq = platform_get_irq(pdev, 0);
3b43c4b4 Miodrag Dinic 2017-07-21 @203 if (rtcdrv->irq < 0)
3b43c4b4 Miodrag Dinic 2017-07-21 204 return -ENODEV;
3b43c4b4 Miodrag Dinic 2017-07-21 205
3b43c4b4 Miodrag Dinic 2017-07-21 206 rtcdrv->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
3b43c4b4 Miodrag Dinic 2017-07-21 207 &goldfish_rtc_ops, THIS_MODULE);
3b43c4b4 Miodrag Dinic 2017-07-21 208 if (IS_ERR(rtcdrv->rtc))
3b43c4b4 Miodrag Dinic 2017-07-21 209 return PTR_ERR(rtcdrv->rtc);
3b43c4b4 Miodrag Dinic 2017-07-21 210
3b43c4b4 Miodrag Dinic 2017-07-21 211 err = devm_request_irq(&pdev->dev, rtcdrv->irq, goldfish_rtc_interrupt,
3b43c4b4 Miodrag Dinic 2017-07-21 212 0, pdev->name, rtcdrv);
3b43c4b4 Miodrag Dinic 2017-07-21 213 if (err)
3b43c4b4 Miodrag Dinic 2017-07-21 214 return err;
3b43c4b4 Miodrag Dinic 2017-07-21 215
3b43c4b4 Miodrag Dinic 2017-07-21 216 return 0;
3b43c4b4 Miodrag Dinic 2017-07-21 217 }
3b43c4b4 Miodrag Dinic 2017-07-21 218
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
reply other threads:[~2017-07-24 4:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1707240652320.3169@hadrien \
--to=julia.lawall@lip6.fr \
--cc=a.zummo@towertech.it \
--cc=aleksandar.markovic@imgtec.com \
--cc=aleksandar.markovic@rt-rk.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=bohu@google.com \
--cc=davem@davemloft.net \
--cc=douglas.leung@imgtec.com \
--cc=goran.ferenc@imgtec.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.hogan@imgtec.com \
--cc=jinqian@google.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=miodrag.dinic@imgtec.com \
--cc=paul.burton@imgtec.com \
--cc=petar.jovanovic@imgtec.com \
--cc=raghu.gandham@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox