From: "'Hans Ulli Kroll' via rtc-linux" <rtc-linux@googlegroups.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: linaro-kernel@lists.linaro.org,
Hans Ulli Kroll <ulli.kroll@googlemail.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [rtc-linux] Re: [PATCH v2 11/22] rtc: gemini: stop using rtc deprecated functions
Date: Wed, 12 Jul 2017 19:20:17 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1707121915310.8002@T420s> (raw)
In-Reply-To: <1499846682-14093-12-git-send-email-benjamin.gaignard@linaro.org>
Hi Benjamin,
On Wed, 12 Jul 2017, Benjamin Gaignard wrote:
> @@ -93,12 +93,12 @@ static int ftrtc010_rtc_set_time(struct device *dev, struct rtc_time *tm)
> {
> struct ftrtc010_rtc *rtc = dev_get_drvdata(dev);
> unsigned int sec, min, hour, day;
> - unsigned long offset, time;
> + unsigned long long offset, time;
>
> if (tm->tm_year >= 2148) /* EPOCH Year + 179 */
> return -EINVAL;
>
> - rtc_tm_to_time(tm, &time);
> + time = rtc_tm_to_time64(tm);
>
> sec = readl(rtc->rtc_base + FTRTC010_RTC_SECOND);
> min = readl(rtc->rtc_base + FTRTC010_RTC_MINUTE);
later on this will do
writel(offset, rtc->rtc_base + FTRTC010_RTC_RECORD);
you are writing some 64bit value in a 32bit register ...
NACK here
Greetings from Cologne
Hans Ulli Kroll
> 1.9.1
>
>
next prev parent reply other threads:[~2017-07-12 17:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1499846682-14093-1-git-send-email-benjamin.gaignard@linaro.org>
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 04/22] rtc: ab-b5ze-s3: stop using rtc deprecated functions Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 05/22] rtc: ab8500: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 06/22] rtc: cpcap: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 07/22] rtc: davinci: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 08/22] rtc: ds1305: " Benjamin Gaignard
2017-07-12 8:30 ` [rtc-linux] " Alexandre Belloni
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 09/22] rtc: ds1511: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 10/22] rtc: ds1553: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 11/22] rtc: gemini: " Benjamin Gaignard
2017-07-12 17:20 ` 'Hans Ulli Kroll' via rtc-linux [this message]
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 12/22] rtc: mv: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 13/22] rtc: omap: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 14/22] rtc: pcap: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 15/22] rtc: rs5c348: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 16/22] rtc: sh: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 17/22] rtc: snvs: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 18/22] rtc: stk17ta8: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 19/22] rtc: sun6i: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 20/22] rtc: sysfs: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 21/22] rtc: test: " Benjamin Gaignard
2017-07-12 8:04 ` [rtc-linux] [PATCH v2 22/22] power: suspend " Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1707121915310.8002@T420s \
--to=rtc-linux@googlegroups.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=benjamin.gaignard@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox