Linux RTC
 help / color / mirror / Atom feed
From: Gregory Price <gourry@gourry.net>
To: sashiko-reviews@lists.linux.dev
Cc: linux-rtc@vger.kernel.org,
	 Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [RESEND PATCH 2/2] rtc: cmos: Honor explicit use_acpi_alarm parameter value
Date: Thu, 15 Oct 2026 17:54:09 -0400	[thread overview]
Message-ID: <atFLRRT_RN7etz3I@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <sashiko-outbox-173258@kernel.org>

On Thu, Oct 15, 2026 at 05:36:16PM +0000, sashiko-bot@kernel.org wrote:
> > +static bool use_acpi_alarm_explicit;
> > +
> > +static int set_use_acpi_alarm(const char *val, const struct kernel_param *kp)
> > +{
> > +	int ret;
> > +
> > +	ret = param_set_bool(val, kp);
> > +	if (!ret)
> > +		use_acpi_alarm_explicit = true;
> 
> [Severity: Low]
> Will this trigger a -Wunused-but-set-variable compiler warning on non-x86
> architectures?
> 
> The file-scoped variable use_acpi_alarm_explicit is declared and unconditionally
> assigned here, but it appears to only be read inside use_acpi_alarm_quirks(),
> which is wrapped in an #ifdef CONFIG_X86 block.
> 
> On architectures like ARM64 or PowerPC, the variable is written to but never
> read.
> 

I could not get this to trigger. Neither gcc nor clang would fire this
warning for a file-scoped static.

~Gregory

      reply	other threads:[~2026-10-15 21:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 17:30 [RESEND PATCH 0/2] rtc: cmos: Fix ACPI RTC alarm handling Gregory Price
2026-10-15 17:30 ` [RESEND PATCH 1/2] rtc: cmos: Disable ACPI RTC event before handling it Gregory Price
2026-10-15 17:42   ` sashiko-bot
2026-10-15 21:53     ` Gregory Price
2026-10-15 17:30 ` [RESEND PATCH 2/2] rtc: cmos: Honor explicit use_acpi_alarm parameter value Gregory Price
2026-10-15 17:36   ` sashiko-bot
2026-10-15 21:54     ` Gregory Price [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atFLRRT_RN7etz3I@gourry-fedora-PF4VCD3F \
    --to=gourry@gourry.net \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-rtc@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox