From: Amelie DELAUNAY <amelie.delaunay@st.com>
To: Markus Elfring <Markus.Elfring@web.de>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] rtc: stm32: One condition check and function call less in stm32_rtc_set_alarm()
Date: Mon, 8 Jul 2019 09:12:52 +0000 [thread overview]
Message-ID: <b614006a-17ac-e738-a3f3-08649f69a42c@st.com> (raw)
In-Reply-To: <4da614a4-83c6-548c-a112-033b846c561b@web.de>
On 7/8/19 10:42 AM, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 8 Jul 2019 10:26:47 +0200
>
> A condition check was repeated in this function implementation despite of
> a corresponding check in the stm32_rtc_alarm_irq_enable() function.
> Thus delete redundant source code here.
>
> Suggested-by: Russell King <linux@armlinux.org.uk>
> Link: https://lore.kernel.org/lkml/20190707211638.sehikkear25dffah@shell.armlinux.org.uk/
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Amelie Delaunay <amelie.delaunay@st.com>
> ---
>
> v2:
> Russell King pointed the change possibility out to omit a condition check
> at this place.
>
>
> drivers/rtc/rtc-stm32.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c
> index 8e6c9b3bcc29..773a1990b93f 100644
> --- a/drivers/rtc/rtc-stm32.c
> +++ b/drivers/rtc/rtc-stm32.c
> @@ -519,11 +519,7 @@ static int stm32_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
> /* Write to Alarm register */
> writel_relaxed(alrmar, rtc->base + regs->alrmar);
>
> - if (alrm->enabled)
> - stm32_rtc_alarm_irq_enable(dev, 1);
> - else
> - stm32_rtc_alarm_irq_enable(dev, 0);
> -
> + stm32_rtc_alarm_irq_enable(dev, alrm->enabled);
> end:
> stm32_rtc_wpr_lock(rtc);
>
> --
> 2.22.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
prev parent reply other threads:[~2019-07-08 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 20:17 [PATCH] rtc: stm32: One function call less in stm32_rtc_set_alarm() Markus Elfring
2019-07-07 21:16 ` Russell King - ARM Linux admin
2019-07-08 8:42 ` [PATCH v2] rtc: stm32: One condition check and " Markus Elfring
2019-07-08 9:12 ` Amelie DELAUNAY [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b614006a-17ac-e738-a3f3-08649f69a42c@st.com \
--to=amelie.delaunay@st.com \
--cc=Markus.Elfring@web.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).