* [PATCH] rtc: pcf85063: hide an unused variable
@ 2025-07-25 9:07 Arnd Bergmann
2025-08-15 21:36 ` Alexander Sverdlin
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2025-07-25 9:07 UTC (permalink / raw)
To: Alexandre Belloni, Antoni Pokusinski
Cc: Arnd Bergmann, Alexander Sverdlin, Ahmad Fatoum, Lukas Stockmann,
Maud Spierings, Oleksij Rempel, linux-rtc, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The newly introduced configuration is only used by code that is
inside of an #ifdef block, cauing a warning when that block is
disabled by the configuration is still there:
drivers/rtc/rtc-pcf85063.c:566:37: error: 'config_rv8063' defined but not used [-Werror=unused-const-variable=]
Add the same #ifdef here.
Fixes: a3c7f7e16ea8 ("rtc: pcf85063: add support for RV8063")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/rtc/rtc-pcf85063.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
index d9b67b959d18..41e4a5a16574 100644
--- a/drivers/rtc/rtc-pcf85063.c
+++ b/drivers/rtc/rtc-pcf85063.c
@@ -563,6 +563,7 @@ static const struct pcf85063_config config_rv8263 = {
.force_cap_7000 = 1,
};
+#if IS_ENABLED(CONFIG_SPI_MASTER)
static const struct pcf85063_config config_rv8063 = {
.regmap = {
.reg_bits = 8,
@@ -574,6 +575,7 @@ static const struct pcf85063_config config_rv8063 = {
.has_alarms = 1,
.force_cap_7000 = 1,
};
+#endif
static int pcf85063_probe(struct device *dev, struct regmap *regmap, int irq,
const struct pcf85063_config *config)
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: pcf85063: hide an unused variable
2025-07-25 9:07 [PATCH] rtc: pcf85063: hide an unused variable Arnd Bergmann
@ 2025-08-15 21:36 ` Alexander Sverdlin
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Sverdlin @ 2025-08-15 21:36 UTC (permalink / raw)
To: Arnd Bergmann, Alexandre Belloni, Antoni Pokusinski
Cc: Arnd Bergmann, Ahmad Fatoum, Lukas Stockmann, Maud Spierings,
Oleksij Rempel, linux-rtc, linux-kernel
On Fri, 2025-07-25 at 11:07 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly introduced configuration is only used by code that is
> inside of an #ifdef block, cauing a warning when that block is
> disabled by the configuration is still there:
>
> drivers/rtc/rtc-pcf85063.c:566:37: error: 'config_rv8063' defined but not used [-Werror=unused-const-variable=]
>
> Add the same #ifdef here.
>
> Fixes: a3c7f7e16ea8 ("rtc: pcf85063: add support for RV8063")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
> drivers/rtc/rtc-pcf85063.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
> index d9b67b959d18..41e4a5a16574 100644
> --- a/drivers/rtc/rtc-pcf85063.c
> +++ b/drivers/rtc/rtc-pcf85063.c
> @@ -563,6 +563,7 @@ static const struct pcf85063_config config_rv8263 = {
> .force_cap_7000 = 1,
> };
>
> +#if IS_ENABLED(CONFIG_SPI_MASTER)
> static const struct pcf85063_config config_rv8063 = {
> .regmap = {
> .reg_bits = 8,
> @@ -574,6 +575,7 @@ static const struct pcf85063_config config_rv8063 = {
> .has_alarms = 1,
> .force_cap_7000 = 1,
> };
> +#endif
>
> static int pcf85063_probe(struct device *dev, struct regmap *regmap, int irq,
> const struct pcf85063_config *config)
--
Alexander Sverdlin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-15 21:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-25 9:07 [PATCH] rtc: pcf85063: hide an unused variable Arnd Bergmann
2025-08-15 21:36 ` Alexander Sverdlin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).