From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: kernel test robot <lkp@intel.com>, <linux-rtc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtc: at91rm9200: annotate at91_rtc_remove with __exit again
Date: Fri, 20 Oct 2023 14:46:43 +0200 [thread overview]
Message-ID: <c339d334-5fe4-4c1a-81ee-42882d93f3e5@microchip.com> (raw)
In-Reply-To: <20231016041816.246426-1-alexandre.belloni@bootlin.com>
On 16/10/2023 at 06:18, alexandre.belloni@bootlin.com wrote:
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
> Without __exit, having the driver as a builtin after dropping the __exit
> annotation results in:
>
>>> drivers/rtc/rtc-at91rm9200.c:561:13: warning: 'at91_rtc_remove' defined but not used [-Wunused-function]
> 561 | static void at91_rtc_remove(struct platform_device *pdev)
> | ^~~~~~~~~~~~~~~
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310160705.vlElNOGb-lkp@intel.com/
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks Alexandre, best regards,
Nicolas
> ---
> drivers/rtc/rtc-at91rm9200.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
> index 3f5ff9867c02..c16fe711a0d9 100644
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -558,7 +558,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev)
> /*
> * Disable and remove the RTC driver
> */
> -static void at91_rtc_remove(struct platform_device *pdev)
> +static void __exit at91_rtc_remove(struct platform_device *pdev)
> {
> /* Disable all interrupts */
> at91_rtc_write_idr(AT91_RTC_ACKUPD | AT91_RTC_ALARM |
> --
> 2.41.0
>
prev parent reply other threads:[~2023-10-20 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 4:18 [PATCH] rtc: at91rm9200: annotate at91_rtc_remove with __exit again alexandre.belloni
2023-10-20 12:46 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c339d334-5fe4-4c1a-81ee-42882d93f3e5@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox