From: "Nuno Sá" <noname.nuno@gmail.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: max31335: fix interrupt status reg
Date: Wed, 21 Feb 2024 14:30:03 +0100 [thread overview]
Message-ID: <ca7d78f6cffc49eba7bb44134c85e94279f1ce95.camel@gmail.com> (raw)
In-Reply-To: <20240219091616.24480-1-antoniu.miclaus@analog.com>
On Mon, 2024-02-19 at 11:16 +0200, Antoniu Miclaus wrote:
> Fix the register value comparison in the `max31335_volatile_reg`
> function for the interrupt status register.
>
> MAX31335_STATUS1 macro definition corresponds to the actual
> interrupt status register.
>
> Fixes: dedaf03b99d6 ("rtc: max31335: add driver support")
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> drivers/rtc/rtc-max31335.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c
> index 402fda8fd548..a2441e5c2c74 100644
> --- a/drivers/rtc/rtc-max31335.c
> +++ b/drivers/rtc/rtc-max31335.c
> @@ -204,7 +204,7 @@ static bool max31335_volatile_reg(struct device *dev, unsigned
> int reg)
> return true;
>
> /* interrupt status register */
> - if (reg == MAX31335_INT_EN1_A1IE)
> + if (reg == MAX31335_STATUS1)
> return true;
>
> /* temperature registers */
next prev parent reply other threads:[~2024-02-21 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 9:16 [PATCH] rtc: max31335: fix interrupt status reg Antoniu Miclaus
2024-02-21 13:30 ` Nuno Sá [this message]
2024-02-29 21:43 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca7d78f6cffc49eba7bb44134c85e94279f1ce95.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=antoniu.miclaus@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox