From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 279503C415E for ; Fri, 14 Aug 2026 16:08:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786723725; cv=none; b=aVKy1XsHuI6yP7KLmBSNruTS9kfCIe6x68iTXvudhLZyK8XjkMaYAhrJdcXkGxlxyIgMR4NlEC73d1eCxP0QYkMUz47U9xbbYt2Q66f4W1sUjOEW/TWxInLwI2qmTsjzV0s9+1+XJ4TZykUWYV5a58TYi1yWf/CurCAZ0YG+NIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786723725; c=relaxed/simple; bh=OvC+uCX22OxiCm/ADZIrl4k/Q2qjrp6B/VU/TsLraGE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p7i8om+EEjZFRQczRagHp7uptqNgfOBG+8klllRQRRNGRnc3ihGDpn2IB1N6d+GHubcZb9XC41zJP0vQGvd2Pz6ZnNahJ3hVd5dj0GhzB281A1T1B6xiUxQxsyF9w+wNDKWprrHymGUER307G6IedefkRfJmRViUoUK33/I/muc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dbuXRXot; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dbuXRXot" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso11605275e9.3 for ; Fri, 14 Aug 2026 09:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786723708; x=1787328508; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6ZnefS8leD5EpLhfx/2yL2ejpM4dklOoHUq4vSAQtGU=; b=dbuXRXot/HKJArG0F0QwksTxblB1A8YetbG+JPqAjp7I8X3WkNNm/Zz9hIbqrF7aw3 5k+YfjsUtRVCrij8euk+f+9D+59K09JS0El0OmQ47uHZBVtKMuttJezWdNcVig0qstn7 QECB+TptQBVlTqxkq3/9vA+GHeEZk5EGmCCawDpR5u8/a1YIRvWFNC2wcg2SHk3Ity78 AisVUaeWcb2CLGcNAwGqEpyFR42QvpyEFwhGorZZfSpKrvmNei0t+3j/ZRKx+ODRuMxc 5Y+luwdrwyl0h+AF5tX+r1EMN36+6p6AI5VvQdDXGHIpwgE206DpdlInaVoP9sJcub2R iKdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786723708; x=1787328508; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=6ZnefS8leD5EpLhfx/2yL2ejpM4dklOoHUq4vSAQtGU=; b=Jrczq0yrvwJUBDJpVjqSNrsZUbRWwnuY9pVpz4j00giWF3C6BjS22e7d4fQuaNpqy8 qiG/LVHkmdq71vvmAOeJsvCnLt0Uni3wvAUOMnRVX8OCQEnvzKY2h4LaY2CAskqXKxUM h53Ko4tdb6CGCs39LdN1hR1IKKMc3Ifr5X0TjFkyeELMuZXn0MXy8Mu9i1q3cnwWCgTZ guLFrwc48rzVqWJAskYrRBQp/gNjRIu5df3kvLRlH/brDYcMVy484aKGlk3soDAZ/oyJ xSykGzvwjk1nceConJrbWnADNYZgyIpRrnEptKwTaXresK1hzFx7ewp5TxqCKWFKgVQq d6TQ== X-Forwarded-Encrypted: i=1; AHgh+RojfI0v09o2NYRwWU7D+NtYesrCOFWCCtejHrCWP/2SGT8bm3TIYxNLVi9aIlq1GE8Rhb5dXI1Ejzw=@vger.kernel.org X-Gm-Message-State: AOJu0YykMeHv8tFQXmi4RBjgWhQku49JBd+0UBlnPAB9om7J0HmfAX6n A+mCsMIt5oeL0TUWywAINDq0r3XNBTs6a77iPpUCBWSfUznjNbn319EO X-Gm-Gg: AR+sD13krOKGhswVG20BSPqmlIFN0vUrrPd8tCNImdY7TCUbGNGmxG2rwLNuyjS17c7 QjkfHvSFjhKjuzxg6R6dmy1M5Lo8Mz9Y8HyagMysrrdqH7P7uietkfClLMndJAQtEdcb1ra1aqE toCk6VlyT+S82usC11/LlsXKYPfIR+EZFwhQ6yrpdQwY2R7bq7unaehpjmMjnZHGF2PQVdNw3JR s3Oa+c2OPY0WO5IczMo+uNhB+6FunmdCVTwLheGfGX+JeLC78QFWb58h5Iu+G/Yfqg91LoOMzBF k0kOGAhbC0tYQHEJS7IcQRcngUNfbHsQCPjisHfgJVNMu04TKrrGdwbWaU+je18zsPnj+bwqILE rDpKSRyIbl85pMcT2sv2488jy1nhd8O28OWE5VE7BFibuzgXwjzLitkfmJ2qnqHeR0pRX84XQ/n CVNbdrWKPLHl/rPKeZYwCqiwCPXxKob8xJkTxH7htO84o2q1q9g182uRFjV1slEJtWSj97MNBAN gGKK5NMoPs4q5hbBSjJZHX3fVw+3HWAXjlg2/hmxt5IXItD9VFwD5ez X-Received: by 2002:a05:600c:138a:b0:499:51cc:4e57 with SMTP id 5b1f17b1804b1-499878cf3b0mr74633095e9.0.1786723707410; Fri, 14 Aug 2026 09:08:27 -0700 (PDT) Received: from [10.128.10.232] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2c18cbsm8127896f8f.29.2026.08.14.09.08.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2026 09:08:26 -0700 (PDT) Sender: Julian Braha Message-ID: Date: Fri, 14 Aug 2026 17:08:25 +0100 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] rtc: pcf8525: Add watchdog support To: Shiv Prakash Gupta , linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org Cc: alexandre.belloni@bootlin.com, krzk+dt@kernel.org, robh@kernel.org, conor+dt@kernel.org, linux@roeck-us.net, wim@linux-watchdog.org, vikash.bansal@nxp.com, priyanka.jain@nxp.com, lakshay.piplani@nxp.com References: <20260807082855.3762394-1-shivprakash.gupta@nxp.com> <20260807082855.3762394-4-shivprakash.gupta@nxp.com> Content-Language: en-US From: Julian Braha In-Reply-To: <20260807082855.3762394-4-shivprakash.gupta@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Shiv, On 8/7/26 09:28, Shiv Prakash Gupta wrote: > Add watchdog support for NXP PCF8525 real time clock(RTC) device > > Signed-off-by: Lakshay Piplani > Signed-off-by: Shiv Prakash Gupta > --- > drivers/rtc/Kconfig | 1 + > drivers/rtc/rtc-pcf8525.c | 245 +++++++++++++++++++++++++++++++++++++- > 2 files changed, 244 insertions(+), 2 deletions(-) > > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index 3c22c7253aae..6c1c7b3d27b6 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -516,6 +516,7 @@ config RTC_DRV_PCF8523 > config RTC_DRV_PCF8525 > tristate "NXP PCF8525" > select REGMAP_I2C > + select WATCHDOG_CORE if WATCHDOG > help Nitpick, sorry: this Kconfig file uses spaces for indentation, but your addition uses a tab. - Julian Braha