From: Marek Vasut <marex@denx.de>
To: Bastian Stender <bst@pengutronix.de>, rtc-linux@googlegroups.com
Cc: Nishanth Menon <nm@ti.com>, Arnd Bergmann <arnd@arndb.de>,
Tony Lindgren <tony@atomide.com>, Felipe Balbi <balbi@ti.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
kernel@pengutronix.de
Subject: [rtc-linux] Re: [PATCH] rtc: ds1307: add OF and ACPI entries for Epson RX8130
Date: Tue, 17 Oct 2017 15:00:23 +0200 [thread overview]
Message-ID: <e07c8587-7527-b927-c356-ed48751f193d@denx.de> (raw)
In-Reply-To: <c4c1e5d6-6c46-1a9a-d7b9-1f34fc1c6296@pengutronix.de>
On 10/17/2017 02:55 PM, Bastian Stender wrote:
> On 10/17/2017 02:49 PM, Marek Vasut wrote:
>> On 10/17/2017 02:46 PM, Bastian Stender wrote:
>>> Make Epson RX8130 device tree and ACPI aware.
>>>
>>> Fixes: ee0981be7704 ("rtc: ds1307: Add support for Epson RX8130CE")
>>
>> Fixes , really ? I don't think it's broken in any way without the ACPI
>> entries.
>
> I think it's incomplete without ACPI/OF support - all other devices do
> have entries there. But yes, it is not really a bug, so this can discarded.
Jupp, this patch is fine, it was just the "fixes" part which looked odd.
--
Best regards,
Marek Vasut
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2017-10-17 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 12:46 [PATCH] rtc: ds1307: add OF and ACPI entries for Epson RX8130 Bastian Stender
2017-10-17 12:49 ` [rtc-linux] " Marek Vasut
2017-10-17 12:55 ` Bastian Stender
2017-10-17 13:00 ` Marek Vasut [this message]
2017-10-26 20:59 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e07c8587-7527-b927-c356-ed48751f193d@denx.de \
--to=marex@denx.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=bst@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=nm@ti.com \
--cc=rtc-linux@googlegroups.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).