From: Guenter Roeck <linux@roeck-us.net>
To: Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
a.zummo@towertech.it, alexandre.belloni@bootlin.com,
jdelvare@suse.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
Subject: Re: [PATCH v2 1/2] drivers: rtc: add max313xx series rtc driver
Date: Wed, 26 Oct 2022 07:53:54 -0700 [thread overview]
Message-ID: <ef7858ae-0236-0f04-ba5a-7302ecb6162e@roeck-us.net> (raw)
In-Reply-To: <20221026131124.289-2-Ibrahim.Tilki@analog.com>
On 10/26/22 06:11, Ibrahim Tilki wrote:
> Adding support for Analog Devices MAX313XX series RTCs.
>
> Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
> Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
Nit below, otherwise for hwmon:
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
[ ... ]
> +
> + if (max313xx->chip->temp_reg) {
> + hwmon = devm_hwmon_device_register_with_info(dev, client->name,
> + max313xx,
> + &max313xx_chip_info,
> + NULL);
> + if (IS_ERR(hwmon))
> + dev_warn(dev, "cannot register hwmon device: %li\n",
> + PTR_ERR(hwmon));
You could use %pe here and just pass hwmon as parameter.
> + }
> +
> + return max313xx_trickle_charger_setup(dev);
> +}
next prev parent reply other threads:[~2022-10-26 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 13:11 [PATCH v2 0/2] drivers: rtc: add max313xx series rtc driver Ibrahim Tilki
2022-10-26 13:11 ` [PATCH v2 1/2] " Ibrahim Tilki
2022-10-26 14:53 ` Guenter Roeck [this message]
2022-10-26 13:11 ` [PATCH v2 2/2] dt-bindings: rtc: add bindings for max313xx RTCs Ibrahim Tilki
2022-10-26 14:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef7858ae-0236-0f04-ba5a-7302ecb6162e@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Ibrahim.Tilki@analog.com \
--cc=Zeynep.Arslanbenzer@analog.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox