From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org
Subject: Re: [PATCH v1] max77663-rtc: pass rtc address from device tree node if exists
Date: Wed, 8 Mar 2023 09:54:28 +0100 [thread overview]
Message-ID: <f1df5968-4322-3f67-3da8-c10ea50386a8@linaro.org> (raw)
In-Reply-To: <20230308083759.11692-1-clamor95@gmail.com>
On 08/03/2023 09:37, Svyatoslav Ryhel wrote:
> MAX77663 PMIC can have RTC on both 0x63 i2c address (like grouper)
> which is main address but on some devices RTC is located on 0x48
> i2c address (like p880 and p895 from LG). Lets add property to be
> able to use alternative address if needed without breaking existing
> bindings.
Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).
Anyway this is not max77663 driver.
The property does not make sense in the context of max77686. Maybe for
max77802/77620 and 77714 would have... but still max77663 is not there.
Don't add properties for unrelated and unsupported devices.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-08 8:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 8:37 [PATCH v1] max77663-rtc: pass rtc address from device tree node if exists Svyatoslav Ryhel
2023-03-08 8:44 ` Alexandre Belloni
2023-03-08 8:46 ` Svyatoslav Ryhel
2023-03-08 8:49 ` Krzysztof Kozlowski
2023-03-08 8:51 ` Svyatoslav Ryhel
2023-03-08 8:55 ` Krzysztof Kozlowski
2023-03-08 8:54 ` Krzysztof Kozlowski [this message]
2023-03-08 8:58 ` Svyatoslav Ryhel
2023-03-08 9:11 ` Krzysztof Kozlowski
2023-03-08 9:14 ` Krzysztof Kozlowski
2023-03-08 9:42 ` Alexandre Belloni
2023-03-08 10:49 ` Krzysztof Kozlowski
2023-03-08 9:29 ` Svyatoslav Ryhel
2023-03-08 10:46 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1df5968-4322-3f67-3da8-c10ea50386a8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=clamor95@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox