From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABD971514CB for ; Mon, 14 Oct 2024 13:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728910898; cv=none; b=LgCxBp46MIhHz6VAQcu6tu0GgWgVXBS+2W9DRQIyaCivX8Z3nxG72Cpr5PxpF8eKCSSxwEPYxft7hLBWxTHQJnc8yOzfFhjBc8HIeAUGXBcBgas9XW/o2fCsPKhmqOsNZaz7/Nsb8BZk+AecrWnzRs0c3f7F9WhtN2/ot0LhY0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728910898; c=relaxed/simple; bh=++dcIeDFDIn2Ao7fa3l8I6kCkaljhMOysKS1UQX8IyI=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=qdkOB7c86c6gMBuMnLwjy3skybX07VVdYWBlPtEagrjJWwR7Sdj1HL4Flwl5sdfoTHmOOUvwBtLxnSuoCzdu14h0ns7isMc9t0DCRpRXgzF6ixeGJ1fJaj4bTCcK5BJDkGefBeECqa9rbCYJH2rfMrmIpt05NtU9qIZgFOHuOgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca; spf=pass smtp.mailfrom=marek.ca; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b=FOXrXD9Y; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marek.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b="FOXrXD9Y" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-7b11692cbcfso312702885a.0 for ; Mon, 14 Oct 2024 06:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek.ca; s=google; t=1728910895; x=1729515695; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=9RHxE4BwKc3ZjDQztQ5oMassHpRi7zp5cvhCSidmTTk=; b=FOXrXD9Yi/AC4n/KEvhIWyGLWXnG4sepYNGZby9xrlR/v6XwIcOI/iIzL5e7NUrcDu ILAh2+lJTnxrJ4cmTobwt/sXB8MB1JzuHRpIP4jzsYED1gIFKzHNPkcQ9L2x+m4cBF7u kXArpHKo48BKhUVTU74QM8XdLSnEcs0kEQNbRx5W05zNWhPoDH3CEK9chaS88bZcCUUQ eSc8iGcC443wWVUiqtHrxNE+Ib/520SZWzQFyd71tQTV+EYF1pqAqM4FPaSORewwOits zH7x7SvRNAtbtwgObgnv6RlD1Ro8mDXoBymEsI8ZIGZFX1NFCxakc8nnApFmwV2wNX0T UQNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728910895; x=1729515695; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9RHxE4BwKc3ZjDQztQ5oMassHpRi7zp5cvhCSidmTTk=; b=wgDw0aXpIPLpuVglgJbB+ZAXn7KmGKlq8wZ4PD9xaOK5SLwb4D2vrqUdn07bj3IX6l 7y3NpBm/9F207LMmedKZumTmZ1ctr6DGic10wNpDpk2SH4vfJdh8Q/23xHQHnSSfWc09 QW+OC2AzgrpcCNfAhyuxNjMEhWluwCD/LQE3hqb1X4sqxoSQXNqPvb4RBget1jd4A/bz gqdIIP/o5nAC5idnJXvN6UTQpbo1y3s/STegEeIcmWLbJ9YLvBtWnkr4a1l5OxW11hV8 F3x9vFDB0y7TN8TrOrF1pQzWQtkWn6r+jjHbG1OMFxdSnqhXkMoY7edTjCcceGsHI0WU gMPw== X-Forwarded-Encrypted: i=1; AJvYcCWvJF7XvVB7U7bKxk3zJ5gd8D/CPrqoStLIs+fTB1dyht8P73918gxDXvFPbjZ47PMTh1JCc/hcGDw=@vger.kernel.org X-Gm-Message-State: AOJu0YyGe4t7LRHveyzibW+6F3hyIj/J7GTwx9K4lDk/l5SpsDd2g7ex ZY9dkAYY8UXycThSeWJ+hNzaMdJ8LCs+eDT68A/um95X458mUbhlOBclDbVmKaI= X-Google-Smtp-Source: AGHT+IGh0QuJA6b0OOwNfoiRKhU3ExuhAHzAqesdDNj776vJw3RQWyW54B6RNyGsIvJBrvQs2fM8Ww== X-Received: by 2002:a05:620a:190f:b0:7ac:a077:6a1e with SMTP id af79cd13be357-7b11a352f87mr1621830785a.9.1728910895574; Mon, 14 Oct 2024 06:01:35 -0700 (PDT) Received: from [192.168.0.189] (modemcable125.110-19-135.mc.videotron.ca. [135.19.110.125]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b11497d799sm413618885a.117.2024.10.14.06.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Oct 2024 06:01:35 -0700 (PDT) Subject: Re: [PATCH v2 2/5] dt-bindings: rtc: qcom-pm8xxx: document no-alarm flag To: Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Satya Priya , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20241013051859.22800-1-jonathan@marek.ca> <20241013051859.22800-3-jonathan@marek.ca> From: Jonathan Marek Message-ID: Date: Mon, 14 Oct 2024 08:58:08 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/14/24 3:34 AM, Krzysztof Kozlowski wrote: > On Sun, Oct 13, 2024 at 01:15:27AM -0400, Jonathan Marek wrote: >> Qualcomm x1e80100 firmware sets the ownership of the RTC alarm to ADSP. >> Thus writing to RTC alarm registers and receiving alarm interrupts is not >> possible. >> >> Add a no-alarm flag to support RTC on this platform. >> >> Signed-off-by: Jonathan Marek >> --- >> Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml b/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml >> index d274bb7a534b5..210f76a819e90 100644 >> --- a/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml >> +++ b/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml >> @@ -40,6 +40,11 @@ properties: >> description: >> Indicates that the setting of RTC time is allowed by the host CPU. >> >> + no-alarm: >> + $ref: /schemas/types.yaml#/definitions/flag >> + description: >> + Indicates that RTC alarm is not owned by HLOS (Linux). > > This is not even properly used/tested, because you disable the RTC > entirely in your DTS. > What? The next patch in this series is enabling RTC on x1e using this flag > I expect here unified property for all Qualcomm devices for this case. > We already have "remotely-controlled" and other flavors. I don't want > each device to express the same with different name... > > Also: missing vendor prefix. > I don't care what the property is named (as long as its a bool property), if you have a name you prefer I will use it. The existing 'allow-set-time' property (also related to HLOS permissions to the RTC) is also specific to this driver doesn't have a vendor prefix. > Best regards, > Krzysztof >