From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>, linux-kernel@vger.kernel.org
Cc: linux-rtc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org, Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH v12 4/5] clocksource/drivers: Add a goldfish-timer clocksource
Date: Wed, 26 Jan 2022 18:25:48 +0100 [thread overview]
Message-ID: <f9119e2f-51e7-e87c-10d9-bc76d6108676@linaro.org> (raw)
In-Reply-To: <1bc0bf2d-49c6-3f68-bc35-919b2a1e4cfc@vivier.eu>
On 26/01/2022 18:14, Laurent Vivier wrote:
> Le 26/01/2022 à 12:55, Daniel Lezcano a écrit :
>>
>> Hi Laurent,
>>
>
> Hi Daniel,
>
>> On 21/01/2022 21:07, Laurent Vivier wrote:
>>> Add a clocksource based on the goldfish-rtc device.
>>
>> As a first submission, please provide a more detailed description of the
>> timer.
>
> ok.
>
> The timer uses in fact the goldifsh RTC clock so I supposed refering to
> drivers/rtc/rtc-goldfish.c could give the missing pieces of information
[ ... ]
> I agree for irq, but res is passed to request_resource() and I think it
> is added to a linked tree, so I'm not sure it can be local to the function.
>
> Do you mean a "static" declaration in the function?
I missed request_resource() was adding the resource in a list, thus the
parameter must not be freed. So discard the comment for 'res'.
[ ... ]
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2022-01-26 17:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 20:07 [PATCH v12 0/5] m68k: Add Virtual M68k Machine Laurent Vivier
2022-01-21 20:07 ` [PATCH v12 1/5] m68k: add asm/config.h Laurent Vivier
2022-01-21 20:07 ` [PATCH v12 2/5] tty: goldfish: introduce gf_ioread32()/gf_iowrite32() Laurent Vivier
2022-01-26 13:41 ` Greg KH
2022-01-26 14:15 ` Arnd Bergmann
2022-01-26 17:32 ` Laurent Vivier
2022-01-21 20:07 ` [PATCH v12 3/5] rtc: goldfish: use gf_ioread32()/gf_iowrite32() Laurent Vivier
2022-01-21 20:07 ` [PATCH v12 4/5] clocksource/drivers: Add a goldfish-timer clocksource Laurent Vivier
2022-01-26 11:55 ` Daniel Lezcano
2022-01-26 17:14 ` Laurent Vivier
2022-01-26 17:25 ` Daniel Lezcano [this message]
2022-01-21 20:07 ` [PATCH v12 5/5] m68k: introduce a virtual m68k machine Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9119e2f-51e7-e87c-10d9-bc76d6108676@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=jiaxun.yang@flygoat.com \
--cc=john.stultz@linaro.org \
--cc=laurent@vivier.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-rtc@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).