From: Matti Vaittinen <mazziesaccount@gmail.com>
To: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Cc: "Karel Balej" <balejk@matfyz.cz>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"André Draszik" <andre.draszik@linaro.org>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v1 3/3] rtc: Use named initializers for platform_device_id arrays
Date: Fri, 29 May 2026 10:33:18 +0300 [thread overview]
Message-ID: <fca8dfd9-f377-44ef-bfdb-b7135f4d39c5@gmail.com> (raw)
In-Reply-To: <d14b9076b2c7703708bcc5cc35f339cd97fc10cd.1779950275.git.u.kleine-koenig@baylibre.com>
On 28/05/2026 09:48, Uwe Kleine-König (The Capable Hub) wrote:
> Named initializers are better readable and more robust to changes of the
> struct definition. This robustness is relevant for a planned change to
> struct platform_device_id replacing .driver_data by an anonymous union.
>
> While touching these arrays unify spacing and usage of commas.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub)<u.kleine-koenig@baylibre.com>
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
--
---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
prev parent reply other threads:[~2026-05-29 7:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 6:48 [PATCH v1 0/3] rtc: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-05-28 6:48 ` [PATCH v1 1/3] rtc: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-05-28 7:43 ` Tzung-Bi Shih
2026-05-28 6:48 ` [PATCH v1 2/3] rtc: ab8500: Simplify driver_data handling Uwe Kleine-König (The Capable Hub)
2026-05-28 13:22 ` Linus Walleij
2026-05-28 6:48 ` [PATCH v1 3/3] rtc: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-05-28 8:40 ` Karel Balej
2026-05-28 13:21 ` Linus Walleij
2026-05-29 7:33 ` Matti Vaittinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fca8dfd9-f377-44ef-bfdb-b7135f4d39c5@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andre.draszik@linaro.org \
--cc=balejk@matfyz.cz \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox