Re: [PATCH 1/2] rtc: renesas-rtca3: Initialize the RTC before requesting interrupts

[sashiko-bot@kernel.org]

> The alarm handler passes priv->rtc_dev to rtc_update_irq(), but the RTC
> allocation is managed after the interrupt requests. Devres can therefore
> drop the RTC's allocation reference before freeing and synchronizing the
> alarm IRQ. Masking alarm interrupts in remove does not wait for a handler
> that has already entered, and a pending alarm flag can still be handled.
> 
> Allocate the RTC before requesting the IRQs so that the allocation
> reference remains valid until the IRQs have been freed and synchronized
> on both removal and probe failure. Initialize its operations and time
> range before requesting the IRQs as well, so an early alarm interrupt
> cannot queue RTC work before the operations are available.
> 
> This issue was found by static analysis.
> 
> Fixes: d4488377609e ("rtc: renesas-rtca3: Add driver for RTCA-3 available on Renesas RZ/G3S SoC")
> Assisted-by: LLM
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011225657.rtca3-irq-ordering.0@gmail.com?part=1