From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-rtc@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] rtc: stm32: release the LSCO clock provider on remove
Date: Tue, 03 Nov 2026 11:05:54 +0000 [thread overview]
Message-ID: <sashiko-outbox-195106@kernel.org> (raw)
In-Reply-To: <20261103105546.1394618-1-vulab@iscas.ac.cn>
> The LSCO pinmux action registers the rtc_lsco clock provider with
> of_clk_add_provider(), which takes a reference on the RTC device node.
> stm32_rtc_remove() unregisters the gate clock but never calls
> of_clk_del_provider(), so the node reference is never dropped and the
> provider stays registered with a pointer to a clock that no longer
> exists.
>
> Delete the provider before unregistering the gate clock.
>
> Fixes: bb7b0df2be5c ("rtc: stm32: add Low Speed Clock Output (LSCO) support")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103105546.1394618-1-vulab@iscas.ac.cn?part=1
next prev parent reply other threads:[~2026-11-03 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 10:55 [PATCH] rtc: stm32: release the LSCO clock provider on remove Wentao Liang
2026-11-03 11:05 ` sashiko-bot [this message]
2026-11-03 11:10 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-195106@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-rtc@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox