Re: [PATCH] rtc: m41t80: use devm for the square wave clock provider

[sashiko-bot@kernel.org]

> m41t80_sqw_register_clk() registers the square wave clock with
> clk_register() and publishes it with of_clk_add_provider(), but neither is
> ever torn down again: m41t80_remove() only unregisters the watchdog.
> 
> The provider therefore keeps a reference to the device node and points at
> m41t80->sqw, which lives in devm-allocated driver data that is freed when
> the device is unbound. Resolving the clock afterwards dereferences freed
> memory.
> 
> Switch to devm_clk_hw_register() and devm_of_clk_add_hw_provider() so that
> the clock and its provider are released with the device. The function no
> longer returns a struct clk pointer, so make it return an int instead.
> 
> Fixes: 1373e77b4f10 ("rtc: m41t80: add clock provider support")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103105808.1395292-1-vulab@iscas.ac.cn?part=1