From: sashiko-bot@kernel.org
To: "Akshat Rawat" <akshatrawat095@gmail.com>
Cc: linux-rtc@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] rtc: as3722: check return value of platform_get_irq()
Date: Sat, 07 Nov 2026 16:16:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-203041@kernel.org> (raw)
In-Reply-To: <20261107160839.422-1-akshatrawat095@gmail.com>
> In as3722_rtc_probe(), the return value of platform_get_irq() is
> assigned to as3722_rtc->alarm_irq without error checking.
>
> If platform_get_irq() fails (such as returning -EPROBE_DEFER when the
> parent interrupt controller is not yet ready), the driver logs an
> invalid IRQ number in dev_info() and calls devm_request_threaded_irq()
> with a negative value. This causes devm_request_threaded_irq() to fail
> with -EINVAL and abort probe permanently, breaking deferred probing.
>
> Check the return value of platform_get_irq() and return immediately on
> failure to properly propagate errors.
>
> Fixes: b45062619840 ("drivers/rtc/rtc-as3722: add RTC driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Akshat Rawat <akshatrawat095@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107160839.422-1-akshatrawat095@gmail.com?part=1
prev parent reply other threads:[~2026-11-07 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 16:08 [PATCH] rtc: as3722: check return value of platform_get_irq() Akshat Rawat
2026-11-07 16:16 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-203041@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akshatrawat095@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-rtc@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox