From: sashiko-bot@kernel.org
To: "Guangshuo Li" <liguangshuo@mail.sdu.edu.cn>
Cc: linux-rtc@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] rtc: hym8563: Fix potential stale clock after device removal
Date: Tue, 10 Nov 2026 14:37:35 +0000 [thread overview]
Message-ID: <sashiko-outbox-207199@kernel.org> (raw)
In-Reply-To: <20261110-9f141e6bc8-rtc-hym8563@mail.sdu.edu.cn>
> The CLKOUT clock and its provider are registered without a matching
> unregister operation. Removal or a later probe failure releases the
> HYM8563 private data containing the clock hardware while the clock is
> still registered.
>
> Manage both registrations with the device so the provider is removed
> before the clock, and both are removed before their backing storage.
>
> This issue was found by our static analysis tool under development.
>
> Fixes: dcaf03849352 ("rtc: add hym8563 rtc-driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-9f141e6bc8-rtc-hym8563@mail.sdu.edu.cn?part=1
prev parent reply other threads:[~2026-11-10 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 14:32 [PATCH] rtc: hym8563: Fix potential stale clock after device removal Guangshuo Li
2026-11-10 14:37 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-207199@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=liguangshuo@mail.sdu.edu.cn \
--cc=linux-rtc@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox