From: sashiko-bot@kernel.org
To: "Igor Velkov" <iav@iav.lv>
Cc: linux-rtc@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v2 5/8] alarmtimer: Keep an RTC per suspend state
Date: Mon, 16 Nov 2026 00:33:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-215950@kernel.org> (raw)
In-Reply-To: <20261116-b4-alarmtimer-rtc-priority-v2-5-b2c69721e489@iav.lv>
> From: Igor Velkov <iav@iav.lv>
>
> alarmtimer takes the first RTC that has an alarm and a wakeup capable
> parent and programs it whatever the suspend state. Which RTC wakes the
> system can depend on the state: on ODROID-HC4, meson-vrtc is a register
> the firmware reads when the application processors suspend, with no
> interrupt in Linux, so it wakes the board from deep sleep only, while the
> pcf8563 wakes it from s2idle.
>
> Keep an RTC per suspend state instead. An RTC takes the states from which
> its alarm wakes the system, minus those an earlier RTC took, and is
> refused when none is left. For now every RTC is taken to wake the system
> from all states, so the first RTC takes all of them, as before.
>
> Link the platform device to each RTC taken, so it suspends before all of
> them. alarmtimer_suspend() programs the RTC of the target state; once an
> RTC can be limited to some states, it rejects the suspend when an alarm
> is pending and no RTC wakes the system from that state.
> alarmtimer_resume() cancels the timer on the RTC it was started on, so
> alarmtimer_suspend() no longer cancels it before starting it.
>
> Signed-off-by: Igor Velkov <iav@iav.lv>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-b4-alarmtimer-rtc-priority-v2-0-b2c69721e489@iav.lv?part=5
next prev parent reply other threads:[~2026-11-16 0:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 0:24 [PATCH v2 0/8] alarmtimer: Pick the wakeup RTC per suspend state Igor Velkov via B4 Relay
2026-11-16 0:25 ` [PATCH v2 1/8] alarmtimer: Replace alarmtimer_get_rtcdev() with alarmtimer_has_rtcdev() Igor Velkov via B4 Relay
2026-11-16 0:29 ` sashiko-bot
2026-11-16 0:25 ` [PATCH v2 2/8] alarmtimer: Move the wakeup state into struct rtc_wakeup Igor Velkov via B4 Relay
2026-11-16 0:29 ` sashiko-bot
2026-11-16 0:25 ` [PATCH v2 3/8] alarmtimer: Replace the freezer delta with per type expiry times Igor Velkov via B4 Relay
2026-11-16 0:34 ` sashiko-bot
2026-11-16 0:25 ` [PATCH v2 4/8] alarmtimer: Register the platform device without a parent Igor Velkov via B4 Relay
2026-11-16 0:33 ` sashiko-bot
2026-11-16 0:25 ` [PATCH v2 5/8] alarmtimer: Keep an RTC per suspend state Igor Velkov via B4 Relay
2026-11-16 0:33 ` sashiko-bot [this message]
2026-11-16 0:25 ` [PATCH v2 6/8] dt-bindings: rtc: Add linux,wakeup-states Igor Velkov via B4 Relay
2026-11-16 0:34 ` sashiko-bot
2026-11-16 0:25 ` [PATCH v2 7/8] alarmtimer: Read the wakeup states of an RTC from linux,wakeup-states Igor Velkov via B4 Relay
2026-11-16 0:33 ` sashiko-bot
2026-11-16 0:25 ` [PATCH v2 8/8] arm64: dts: amlogic: meson-sm1-odroid-hc4: Describe which RTC wakes the board Igor Velkov via B4 Relay
2026-11-16 0:32 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215950@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=iav@iav.lv \
--cc=linux-rtc@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox