Linux RTC
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Igor Velkov" <iav@iav.lv>
Cc: linux-rtc@vger.kernel.org,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] rtc: meson-vrtc: keep the alarm across the hibernation snapshot
Date: Tue, 17 Nov 2026 20:23:46 +0000	[thread overview]
Message-ID: <sashiko-outbox-219594@kernel.org> (raw)
In-Reply-To: <20261117-meson-vrtc-thaw-v1-1-b58a2c3919d3@iav.lv>

> From: Igor Velkov <iav@iav.lv>
> 
> SIMPLE_DEV_PM_OPS also installs meson_vrtc_resume() as the .thaw
> callback, so the alarm is cleared as soon as the hibernation image has
> been created. An alarm set through the RTC (rtcwake, wakealarm) is then
> lost: with hybrid-sleep the system suspends with a zero wakeup time in
> the SCP and does not wake on it. The alarmtimer is not affected, as it
> sets the alarm again from its own suspend callback.
> 
> Set only the suspend/resume and poweroff/restore callbacks, so freeze
> and thaw leave the alarm alone.
> 
> Tested on ODROID-HC4 with v7.4-rc3, rtcwake -m no before hybrid-sleep:
> BL301 printed alarm=0S before this change and the remaining time with
> it, and woke the board on the alarm 3 of 3 times. Waking needs a BL301
> that acts on this alarm; the stock one for HC4 does not. Deep suspend
> still wakes on the alarm.
> 
> Fixes: 6ef35398e827 ("rtc: Add Amlogic Virtual Wake RTC")
> Signed-off-by: Igor Velkov <iav@iav.lv>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-meson-vrtc-thaw-v1-1-b58a2c3919d3@iav.lv?part=1


      reply	other threads:[~2026-11-17 20:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 20:13 [PATCH] rtc: meson-vrtc: keep the alarm across the hibernation snapshot Igor Velkov via B4 Relay
2026-11-17 20:23 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219594@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=iav@iav.lv \
    --cc=linux-rtc@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox