From mboxrd@z Thu Jan 1 00:00:00 1970 From: Farhan Ali Date: Thu, 08 Feb 2018 15:28:56 +0000 Subject: Re: [PATCH v2 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support Message-Id: <00fb2500-7656-f604-4253-3b7e73b9730a@linux.vnet.ibm.com> References: <246f92c9-15dc-223f-59d9-b2f0756cdf5e@de.ibm.com> <1610039.4trOurtpys@amdc3058> In-Reply-To: <1610039.4trOurtpys@amdc3058> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Archive: List-Post: To: Bartlomiej Zolnierkiewicz , Christian Borntraeger Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-fbdev@vger.kernel.org, geert@linux-m68k.org, stefan.kristiansson@saunalahti.fi, tomi.valkeinen@ti.com, schwidefsky@de.ibm.com, dri-devel@lists.freedesktop.org, Chen Liqin , Lennox Wu , Jeff Dike , Richard Weinberger , user-mode-linux-devel@lists.sourceforge.net List-ID: On 02/08/2018 08:11 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > [ dri-devel ML & arch/[score,um] Maintainers added to Cc: ] > > On Friday, February 02, 2018 08:59:57 AM Christian Borntraeger wrote: >> On 02/01/2018 07:41 PM, Farhan Ali wrote: >>> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' >>> added the HAS_IOMEM dependecy for "Graphics support". This disabled the >>> "Graphics support" menu for S390. But if we enable VT layer for S390, >>> we would also need to enable the dummy console. So let's remove the >>> HAS_IOMEM dependency. >>> >>> Move this dependency to Opencores framebuffer driver which would fail to build >>> with CONFIG_HAS_IOMEM disabled: >>> >>> ERROR: "devm_ioremap_resource" [drivers/video/fbdev/ocfb.ko] undefined! > > "Graphics support" menu covers other things (i.e. DRM), I assume that > they were also checked to not break due to this change? > Yes, DRM compiled fine. And we (s390) would need the DRM subsystem for Virtio GPU as well. > Moreover it seems that after this change "Graphics support" menu will > be also enabled (besides s390) for score, tile and um architectures, > I assume that this is okay? > >>> Signed-off-by: Farhan Ali >>> Tested-by: Dong Jia Shi >> >> This also enables several PCI based graphic device driver on s390. >> This makes no sense but they all compile fine so I guess this is ok. >> >> I think patch 2 and 3 are clearly for the s390 tree, patch 1 seems trivial >> Also ccing Bart. Can we maybe get an ack to carry this patch also via the s390 >> tree? >> >> >>> --- >>> drivers/video/Kconfig | 1 - >>> drivers/video/fbdev/Kconfig | 2 +- >>> 2 files changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >>> index 3c20af9..41e7ba9 100644 >>> --- a/drivers/video/Kconfig >>> +++ b/drivers/video/Kconfig >>> @@ -3,7 +3,6 @@ >>> # >>> >>> menu "Graphics support" >>> - depends on HAS_IOMEM >>> >>> config HAVE_FB_ATMEL >>> bool >>> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig >>> index 2f615b7..ec9c9ce 100644 >>> --- a/drivers/video/fbdev/Kconfig >>> +++ b/drivers/video/fbdev/Kconfig >>> @@ -966,7 +966,7 @@ config FB_PVR2 >>> >>> config FB_OPENCORES >>> tristate "OpenCores VGA/LCD core 2.0 framebuffer support" >>> - depends on FB && HAS_DMA >>> + depends on FB && HAS_DMA && HAS_IOMEM >>> select FB_CFB_FILLRECT >>> select FB_CFB_COPYAREA >>> select FB_CFB_IMAGEBLIT > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics >