From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fra-out-004.esa.eu-central-1.outbound.mail-perimeter.amazon.com (fra-out-004.esa.eu-central-1.outbound.mail-perimeter.amazon.com [3.74.81.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08824389440; Thu, 22 Jan 2026 20:41:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=3.74.81.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769114486; cv=none; b=Wi0uEkevEO1aWPnf2y6HYYxiGqkXTQtxRewbOagjY/urlbtPTXLuG1gQB9MAVBriQc9PQhtRRvw3yOWB1VpBXwfh5TME9nTZPF4jf+Pb5s466qUMuUuqPbeRtAm6aMRfPV8PR5cOan+WM7z3YSTFDAzc5x/nQQpsg2QjVRrpXE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769114486; c=relaxed/simple; bh=LonPtWha4x8xuSmcztKfYqypFSPHpLZl16paREdrt8M=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=tBpsHwoZwG1JMuNnjGbIy3cGGHuTSiGvk3VHQDz/gP7Lj3ksdYwrird8jLrvr7g/3ZR5jcD3JHlof3KqoMyzxRLRfprJ366Xxkw1W6dVIKLNEBnyDKC5ej98cFO3OHZB/6DpOZWbyPMMrNiMoIj7fR8NcYfUTnTSI9IUhasSIeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.uk; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=SCmRGBJh; arc=none smtp.client-ip=3.74.81.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="SCmRGBJh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1769114480; x=1800650480; h=message-id:date:mime-version:reply-to:subject:to:cc: references:from:in-reply-to:content-transfer-encoding; bh=L060fUvGttxYBIHa6eLU8Z48SLaOwnhKGvQs72E5QZs=; b=SCmRGBJhNyXtpYiJKtHywhQ3vlbN3/T3F4Y2L8whBJAfJcCtGq59YV6k IfqNX+2Vn+zqIr//fQgpfpFFODHMyhzTkK6ZkSHqfDuc7h0xmV1gOjxKU QIr11WoHQLZsS5AQSJ8mo7LoHjYlJy64VBfs9Cmq2B9RNNWtQcT5lNaa6 rhzQVZ6KsnsqpBLe58WbTq5NKK9zpwbmgPirLsNvw6kGNb71qmhe/9eDS VvZSgTS4E4jenFoFB36tW1/nVrZzCCt8apbYolXuBRdLuTib+eudUNLrV g5ogb6vDyGAfxksDqAOswDYU2obRaB8qGKvR7lvLxr8L6otMmcTM6VdA/ A==; X-CSE-ConnectionGUID: Eq/qtYVnSJqlAvEbKUczXA== X-CSE-MsgGUID: JuRcDWNSTV2iEyPOM5D09w== X-IronPort-AV: E=Sophos;i="6.21,246,1763424000"; d="scan'208";a="8319239" Received: from ip-10-6-6-97.eu-central-1.compute.internal (HELO smtpout.naws.eu-central-1.prod.farcaster.email.amazon.dev) ([10.6.6.97]) by internal-fra-out-004.esa.eu-central-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2026 20:40:53 +0000 Received: from EX19MTAEUA001.ant.amazon.com [54.240.197.233:3034] by smtpin.naws.eu-central-1.prod.farcaster.email.amazon.dev [10.0.29.47:2525] with esmtp (Farcaster) id a5dd7989-855e-4510-b2e9-5fd9107a3c02; Thu, 22 Jan 2026 20:40:52 +0000 (UTC) X-Farcaster-Flow-ID: a5dd7989-855e-4510-b2e9-5fd9107a3c02 Received: from EX19D005EUB003.ant.amazon.com (10.252.51.31) by EX19MTAEUA001.ant.amazon.com (10.252.50.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Thu, 22 Jan 2026 20:40:51 +0000 Received: from [192.168.23.186] (10.106.82.17) by EX19D005EUB003.ant.amazon.com (10.252.51.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Thu, 22 Jan 2026 20:40:47 +0000 Message-ID: <0635e64a-2194-4a6c-b772-28af54d58e3b@amazon.com> Date: Thu, 22 Jan 2026 20:40:46 +0000 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Subject: Re: [PATCH v9 07/13] KVM: guest_memfd: Add flag to remove from direct map To: Ackerley Tng , "Kalyazin, Nikita" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "kernel@xen0n.name" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "loongarch@lists.linux.dev" CC: "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oupton@kernel.org" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "seanjc@google.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "david@kernel.org" , "lorenzo.stoakes@oracle.com" , "Liam.Howlett@oracle.com" , "vbabka@suse.cz" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "song@kernel.org" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jolsa@kernel.org" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "shuah@kernel.org" , "riel@surriel.com" , "ryan.roberts@arm.com" , "jgross@suse.com" , "yu-cheng.yu@intel.com" , "kas@kernel.org" , "coxu@redhat.com" , "kevin.brodsky@arm.com" , "maobibo@loongson.cn" , "prsampat@amd.com" , "mlevitsk@redhat.com" , "jmattson@google.com" , "jthoughton@google.com" , "agordeev@linux.ibm.com" , "alex@ghiti.fr" , "aou@eecs.berkeley.edu" , "borntraeger@linux.ibm.com" , "chenhuacai@kernel.org" , "dev.jain@arm.com" , "gor@linux.ibm.com" , "hca@linux.ibm.com" , "Jonathan.Cameron@huawei.com" , "palmer@dabbelt.com" , "pjw@kernel.org" , "shijie@os.amperecomputing.com" , "svens@linux.ibm.com" , "thuth@redhat.com" , "wyihan@google.com" , "yang@os.amperecomputing.com" , "vannapurve@google.com" , "jackmanb@google.com" , "aneesh.kumar@kernel.org" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Itazuri, Takahiro" , "Manwaring, Derek" , "Cali, Marco" References: <20260114134510.1835-1-kalyazin@amazon.com> <20260114134510.1835-8-kalyazin@amazon.com> Content-Language: en-US From: Nikita Kalyazin Autocrypt: addr=kalyazin@amazon.com; keydata= xjMEY+ZIvRYJKwYBBAHaRw8BAQdA9FwYskD/5BFmiiTgktstviS9svHeszG2JfIkUqjxf+/N JU5pa2l0YSBLYWx5YXppbiA8a2FseWF6aW5AYW1hem9uLmNvbT7CjwQTFggANxYhBGhhGDEy BjLQwD9FsK+SyiCpmmTzBQJnrNfABQkFps9DAhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQr5LK IKmaZPOpfgD/exazh4C2Z8fNEz54YLJ6tuFEgQrVQPX6nQ/PfQi2+dwBAMGTpZcj9Z9NvSe1 CmmKYnYjhzGxzjBs8itSUvWIcMsFzjgEY+ZIvRIKKwYBBAGXVQEFAQEHQCqd7/nb2tb36vZt ubg1iBLCSDctMlKHsQTp7wCnEc4RAwEIB8J+BBgWCAAmFiEEaGEYMTIGMtDAP0Wwr5LKIKma ZPMFAmes18AFCQWmz0MCGwwACgkQr5LKIKmaZPNTlQEA+q+rGFn7273rOAg+rxPty0M8lJbT i2kGo8RmPPLu650A/1kWgz1AnenQUYzTAFnZrKSsXAw5WoHaDLBz9kiO5pAK In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EX19D004EUC003.ant.amazon.com (10.252.51.249) To EX19D005EUB003.ant.amazon.com (10.252.51.31) On 22/01/2026 20:30, Ackerley Tng wrote: > Nikita Kalyazin writes: > >> >> [...snip...] >> >>>>>> @@ -533,6 +580,8 @@ static void kvm_gmem_free_folio(struct folio *folio) >>>>>> kvm_pfn_t pfn = page_to_pfn(page); >>>>>> int order = folio_order(folio); >>>>>> >>>>>> + kvm_gmem_folio_restore_direct_map(folio); >>>>>> + >>>>> >>>>> I can't decide if the kvm_gmem_folio_no_direct_map(folio) should be in >>>>> the caller or within kvm_gmem_folio_restore_direct_map(), since this >>>>> time it's a folio-specific property being checked. >>>> >>>> I'm tempted to keep it similar to the kvm_gmem_folio_zap_direct_map() >>>> case. How does the fact it's a folio-speicific property change your >>>> reasoning? >>>> >>> >>> This is good too: >>> >>> if (kvm_gmem_folio_no_direct_map(folio)) >>> kvm_gmem_folio_restore_direct_map(folio) >> >> It turns out we can't do that because folio->mapping is gone by the time >> filemap_free_folio() is called so we can't inspect the flags. Are you >> ok with only having this check when zapping (but not when restoring)? >> Do you think we should add a comment saying it's conditional here? >> > > I thought kvm_gmem_folio_no_direct_map() only reads folio->private, > which I think should still be there at the point of > filemap_free_folio(). Oh, I misread your last reply. What you're proposing would work indeed. > >>> >>> [...snip...] >>>