Re: [PATCH v14 5/7] vfio-pci/zdev: Add a device feature for error information

Niklas Schnelle
2026-04-30T08:36:41Z

On Wed, 2026-04-29 at 09:59 -0700, Farhan Ali wrote:
> On 4/29/2026 2:40 AM, Niklas Schnelle wrote:
> > > +struct vfio_device_feature_zpci_err {
> > > + __u32 flags; /* Indicate feature in non CCDF reserved space */
> > The "non CCDF" feels a bit subtle for marking this as a vfio-pci
> > feature specific field. Maybe call it "vfio_feat_flags"?
>
> I was a little hesitant about naming it with vfio as it's not exactly
> tied to anything in vfio framework. But if you feel strongly will change it.

Maybe just feature_flags?

Thanks,
Niklas
> >