From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726009AbgIRIw6 (ORCPT ); Fri, 18 Sep 2020 04:52:58 -0400 Subject: Re: [PATCH 02/14] block: switch register_disk to use blkdev_get_by_dev References: <20200917165720.3285256-1-hch@lst.de> <20200917165720.3285256-3-hch@lst.de> From: Sergei Shtylyov Message-ID: <091931b1-eb9c-e45e-c9e8-501554618508@gmail.com> Date: Fri, 18 Sep 2020 11:52:39 +0300 MIME-Version: 1.0 In-Reply-To: <20200917165720.3285256-3-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-ID: To: Christoph Hellwig , Jens Axboe Cc: Josef Bacik , Minchan Kim , Stefan Haberland , Jan Hoeppner , Joseph Qi , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Andrew Morton , linux-kernel@vger.kernel.org, nbd@other.debian.org, linux-ide@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-pm@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org Hello! On 17.09.2020 19:57, Christoph Hellwig wrote: > Use blkdev_get_by_dev instead of open coding it using bdget_disk + > blkdev_get. I don't see where you are removing bdget_disk() call (situated just before the below code?)... > Signed-off-by: Christoph Hellwig > --- > block/genhd.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/block/genhd.c b/block/genhd.c > index 7b56203c90a303..f778716fac6cde 100644 > --- a/block/genhd.c > +++ b/block/genhd.c > @@ -732,10 +732,9 @@ static void register_disk(struct device *parent, struct gendisk *disk, > goto exit; > > set_bit(GD_NEED_PART_SCAN, &disk->state); > - err = blkdev_get(bdev, FMODE_READ, NULL); > - if (err < 0) > - goto exit; > - blkdev_put(bdev, FMODE_READ); > + bdev = blkdev_get_by_dev(disk_devt(disk), FMODE_READ, NULL); > + if (!IS_ERR(bdev)) > + blkdev_put(bdev, FMODE_READ); > > exit: > /* announce disk after possible partitions are created */ MBR, Sergei