Re: [PATCH net-next 01/18] net/smc: decouple ism_dev from SMC-D device dump

Gerd Bayer
2023-09-22T18:13:26Z

On Fri, 2023-09-22 at 16:05 +0800, Wen Gu wrote:
> On 2023/9/22 04:41, Simon Horman wrote:
> > On Tue, Sep 19, 2023 at 10:41:45PM +0800, Wen Gu wrote:
> >
> > priv_dev is uninitialised here.
> >
> > > -       smc_set_pci_values(to_pci_dev(ism->dev.parent),
> > > &smc_pci_dev);
> > > +       if (smcd->ops->get_dev)
> > > +               priv_dev = smcd->ops->get_dev(smcd);
> >
> > It is conditionally initialised here.
> >
> > > +       if (priv_dev->parent)
> >
> > But unconditionally dereferenced here.
> >
> > As flagged by clang-16 W=1, and Smatch
> >
>
> Hi Simon. Yes, I fixed it in v3. Thank you!

Hi Wen Gu,

seems like there is some email filter at work. Neither v2 nor v3 made
it to the netdev mailing list - nor to patchwork.kernel.org.
There's traces of Wenjia's replies and your replies to her - but not
the original mail.

Could you please check? Thanks!
Gerd