Re: [PATCH 5/7] block: remove (__)blkdev_reread_part as an exported API

Hannes Reinecke
2019-11-15T10:08:24Z

On 11/14/19 3:34 PM, Christoph Hellwig wrote:
> In general drivers should never mess with partition tables directly.
> Unfortunately s390 and loop do for somewhat historic reasons, but they
> can use bdev_disk_changed directly instead when we export it as they
> satisfy the sanity checks we have in __blkdev_reread_part.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Stefan Haberland <sth@linux.ibm.com> [dasd]
> Reviewed-by: Jan Kara <jack@suse.cz>
> ---
> block/ioctl.c | 35 +++++----------------------------
> drivers/block/loop.c | 13 +++++++-----
> drivers/s390/block/dasd_genhd.c | 4 +++-
> fs/block_dev.c | 7 +++++++
> include/linux/fs.h | 2 --
> 5 files changed, 23 insertions(+), 38 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer