Re: [patch 3/6] arch_update_pgd call

Martin Schwidefsky
2007-10-26T08:22:50Z

On Fri, 2007-10-26 at 17:59 +1000, Benjamin Herrenschmidt wrote:
> > > I'm not at all fan of the hook there and it's name...
> > >
> > > Any reason why you can't do that in your arch gua ?
> > >
> > > If not, then why can't you call it something nicer, like
> > > arch_rebalance_pgtables() ?
> >
> > The name can be changed in no time. I've tried to use one of the
> > existing arch calls like arch_mmap_check or arch_get_unmapped_area but
> > it didn't work out. I really need the final address to make the call to
> > extend the page tables.
>
> You arch get_unmapped_area() has it...

Hmm, I got worried about the file->f_op->get_unmapped_area indirection.
At least the get_unmapped_area_mem function in drivers/char/mem.c does
not call the standard get_unmapped_area function again like ipc/shm.c
does. As I see it is not guaranteed that the architecture version of
arch_get_unmapped_area gets control. Want to play safe there.