Re: [PATCH 2/4] panic: Allow taint flag for warnings to be changed from TAINT_WARN

Ben Hutchings
2010-03-23T13:20:40Z

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

On Mon, 2010-03-22 at 22:47 -0400, Andrew Morton wrote:
> On Sat, 20 Mar 2010 23:05:40 +0000 Ben Hutchings <ben@decadent.org.uk> wrote:
>
> > WARN() is used in some places to report firmware or hardware bugs that
> > are then worked-around. These bugs do not affect the stability of the
> > kernel and should not set the usual TAINT_WARN flag. To allow for
> > this, add WARN_TAINT() and WARN_TAINT_ONCE() macros that take a taint
> > flag as argument.
> >
> > Architectures that implement warnings using trap instructions instead
> > of calls to warn_slowpath_*() must now implement __WARN_TAINT(taint)
> > instead of __WARN().
>
> When you say they "must now implement", I assume that you mean that
> they _do_ now implement, and that no additional architecture work is
> needed.

Right, I believe I fixed-up all the current architectures. There might
be more architectures out there, unmerged as yet.

Ben.

--
Ben Hutchings
Any smoothly functioning technology is indistinguishable from a rigged demo.