From: James Bottomley <James.Bottomley@suse.de>
To: Christof Schmitt <christof.schmitt@de.ibm.com>
Cc: linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com
Subject: Re: [patch 02/10] zfcp: Remove SCSI device when removing unit
Date: Tue, 27 Jul 2010 15:37:55 -0500 [thread overview]
Message-ID: <1280263075.2833.404.camel@mulgrave.site> (raw)
In-Reply-To: <20100716134300.006377000@de.ibm.com>
On Fri, 2010-07-16 at 15:37 +0200, Christof Schmitt wrote:
> plain text document attachment (705-zfcp-unit-removal.diff)
> From: Christof Schmitt <christof.schmitt@de.ibm.com>
>
> Configuring a LUN in zfcp, also creates a SCSI device. For
> consistency, it makes sense to remove the SCSI device when the LUN is
> deconfigured. Replace the flush_work with the call to
> scsi_remove_device: scsi_remove_device also takes the scan_mutex that
> synchronizes itself with any long running device discovery.
This one's rejecting:
jejb@mulgrave:~/git/scsi-misc-2.6> patch -p1 < ~/tmp/tmp/02
patching file drivers/s390/scsi/zfcp_def.h
patching file drivers/s390/scsi/zfcp_scsi.c
Hunk #1 FAILED at 564.
1 out of 1 hunk FAILED -- saving rejects to file
drivers/s390/scsi/zfcp_scsi.c.rej
It looks like a missing patch somewhere.
Could you check the current state of scsi-misc-2.6 (it includes
scsi-rc-fixes-2.6) and see if I've lost something?
Thanks,
James
next prev parent reply other threads:[~2010-07-27 20:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 13:37 [patch 00/10] zfcp updates for 2.6.36 merge window Christof Schmitt
2010-07-16 13:37 ` [patch 01/10] zfcp: Use memdup_user and kstrdup Christof Schmitt
2010-07-16 13:37 ` [patch 02/10] zfcp: Remove SCSI device when removing unit Christof Schmitt
2010-07-27 20:37 ` James Bottomley [this message]
2010-07-28 8:35 ` Christof Schmitt
2010-07-16 13:37 ` [patch 03/10] zfcp: Use correct width for timer_interval field Christof Schmitt
2010-07-16 13:37 ` [patch 04/10] zfcp: Cleanup function parameters for sbal value Christof Schmitt
2010-07-16 13:37 ` [patch 05/10] zfcp: Cleanup QDIO attachment and improve processing Christof Schmitt
2010-07-16 13:37 ` [patch 06/10] zfcp: Post events through FC transport class Christof Schmitt
2010-07-16 13:37 ` [patch 07/10] zfcp: Prevent access on uninitialized memory Christof Schmitt
2010-07-16 13:37 ` [patch 08/10] zfcp: Enable data division support for FCP devices Christof Schmitt
2010-07-16 13:37 ` [patch 09/10] zfcp: Introduce experimental support for DIF/DIX Christof Schmitt
2010-07-16 13:37 ` [patch 10/10] zfcp: Trigger logging in the FCP channel on qdio error conditions Christof Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280263075.2833.404.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=christof.schmitt@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).