Re: [PATCH 0/5] make *_gate_vma accept mm_struct instead of task_struct

Stephen Wilson
2011-03-09T14:14:41Z

On Wed, Mar 09, 2011 at 05:09:09AM -0800, Michel Lespinasse wrote:
> On Tue, Mar 8, 2011 at 4:31 PM, Stephen Wilson <wilsons@start.ca> wrote:
> > Morally, the question of whether an address lies in a gate vma should be asked
> > with respect to an mm, not a particular task.
> >
> > Practically, dropping the dependency on task_struct will help make current and
> > future operations on mm's more flexible and convenient. In particular, it
> > allows some code paths to avoid the need to hold task_lock.
>
> Reviewed-by: Michel Lespinasse <walken@google.com>
>
> May I suggest ia32_compat instead of just compat for the flag name ?

Yes, sounds good to me. Will change in the next iteration.

Thanks for the review!

> --
> Michel "Walken" Lespinasse
> A program is never fully debugged until the last user dies.

--
steve