From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EE39C678D4 for ; Tue, 17 Jan 2023 15:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232992AbjAQPKG (ORCPT ); Tue, 17 Jan 2023 10:10:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233040AbjAQPJr (ORCPT ); Tue, 17 Jan 2023 10:09:47 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2A1B3EFFD; Tue, 17 Jan 2023 07:09:46 -0800 (PST) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30HF4U7u035767; Tue, 17 Jan 2023 15:09:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=JFx46jgzCiXkYs+fCTaUtsu50MGftVReNl1FQHY3A4s=; b=hxL8FaQ9UUUsKHQWJQqI/jm6dmNsRpgrMow9wX0n8bS/xgBpZPTmSZAeNc0ZlWwkEEZR l1upCNW1GNaK6I1se62lRcocY0CRx1FIfm9XkqgHMd9Oo0xrZnHBaisiBSW0+tW5vWI1 5Pwt18ZJR4mKVtRM151EMe2G+TkMT/SuUqtBxhW3y8erEyPn0GhFBsWrZIfdbTgqsAs8 8rmnJRUj4fF4BQYtMRobGaUIzvvt6RP9xKUCdI7ElJTWYgNuQ2NmbclEUFj2zl4U+Tek r9gx0QeRCARb/4SCBk//sA2ZthwdiNUwTOUVh1XH6hlEHrULAcxyIeMG/1Eno81CQ25r Yw== Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3n5qb62aan-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jan 2023 15:09:33 +0000 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30HEDjkG013729; Tue, 17 Jan 2023 15:09:32 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([9.208.130.99]) by ppma01wdc.us.ibm.com (PPS) with ESMTPS id 3n3m17006y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jan 2023 15:09:32 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30HF9VUf37552570 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Jan 2023 15:09:31 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8A41858064; Tue, 17 Jan 2023 15:09:31 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2888058061; Tue, 17 Jan 2023 15:09:30 +0000 (GMT) Received: from [9.160.180.199] (unknown [9.160.180.199]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 17 Jan 2023 15:09:30 +0000 (GMT) Message-ID: <12fb284e-8669-7761-60e6-91dbc66d5d9a@linux.ibm.com> Date: Tue, 17 Jan 2023 10:09:29 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v4 1/7] s390/ism: Set DMA coherent mask Content-Language: en-US To: Niklas Schnelle , Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Wenjia Zhang Cc: Gerd Bayer , Pierre Morel , iommu@lists.linux.dev, linux-s390@vger.kernel.org, borntraeger@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com, svens@linux.ibm.com, linux-kernel@vger.kernel.org, Julian Ruess References: <20230104120543.308933-1-schnelle@linux.ibm.com> <20230104120543.308933-2-schnelle@linux.ibm.com> From: Matthew Rosato In-Reply-To: <20230104120543.308933-2-schnelle@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: tmYqfN4oPqjc4bK_Zr3t4scsdSx1Kq9M X-Proofpoint-ORIG-GUID: tmYqfN4oPqjc4bK_Zr3t4scsdSx1Kq9M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-17_06,2023-01-17_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 clxscore=1015 bulkscore=0 malwarescore=0 mlxlogscore=794 suspectscore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301170122 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 1/4/23 7:05 AM, Niklas Schnelle wrote: > A future change will convert the DMA API implementation from the > architecture specific arch/s390/pci/pci_dma.c to using the common code > drivers/iommu/dma-iommu.c which the utilizes the same IOMMU hardware > through the s390-iommu driver. Unlike the s390 specific DMA API this > requires devices to correctly call set the coherent mask to be allowed > to use IOVAs >2^32 in dma_alloc_coherent(). This was however not done > for ISM devices. ISM requires such addresses since currently the DMA > aperture for PCI devices starts at 2^32 and all calls to > dma_alloc_coherent() would thus fail. > > Reviewed-by: Alexandra Winter > Signed-off-by: Niklas Schnelle Reviewed-by: Matthew Rosato