From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Julia Lawall Subject: [PATCH] arch/s390/kernel/ipl.c: correct error detection check Date: Mon, 22 Aug 2011 13:46:34 +0200 Message-Id: <1314013594-25651-1-git-send-email-julia@diku.dk> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Martin Schwidefsky Cc: kernel-janitors@vger.kernel.org, Heiko Carstens , linux390@de.ibm.com, Michael Holzheu , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, sumsaha@gmail.com List-ID: From: Julia Lawall reipl_fcp_kset was just initialized, so it appears that it should be tested instead of reipl_kset. Signed-off-by: Julia Lawall Reported-by: Suman Saha --- arch/s390/kernel/ipl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/kernel/ipl.c b/arch/s390/kernel/ipl.c index 04361d5..ee28e06 100644 --- a/arch/s390/kernel/ipl.c +++ b/arch/s390/kernel/ipl.c @@ -1220,7 +1220,7 @@ static int __init reipl_fcp_init(void) /* sysfs: create fcp kset for mixing attr group and bin attrs */ reipl_fcp_kset = kset_create_and_add(IPL_FCP_STR, NULL, &reipl_kset->kobj); - if (!reipl_kset) { + if (!reipl_fcp_kset) { free_page((unsigned long) reipl_block_fcp); return -ENOMEM; }