From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [patch 1/2] kdump: Initialize vmcoreinfo note at startup From: Michael Holzheu Reply-To: holzheu@linux.vnet.ibm.com In-Reply-To: <20110920155912.d107fd49.akpm@google.com> References: <20110920143400.776127689@linux.vnet.ibm.com> <20110920143436.019045253@linux.vnet.ibm.com> <20110920155912.d107fd49.akpm@google.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 21 Sep 2011 10:49:08 +0200 Message-ID: <1316594948.3888.3.camel@br98xy6r> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Andrew Morton Cc: vgoyal@redhat.com, ebiederm@xmission.com, mahesh@linux.vnet.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Andrew Morton List-ID: Hello Andrew, On Tue, 2011-09-20 at 15:59 -0700, Andrew Morton wrote: > On Tue, 20 Sep 2011 16:34:01 +0200 [snip] > Michael Holzheu wrote: > > -void crash_save_vmcoreinfo(void) > > +static void update_vmcoreinfo_note(void) > > { > > - u32 *buf; > > + u32 *buf = (u32 *) vmcoreinfo_note; > > The cast is unneeded? Correct. I removed the cast (with the blank :), thanks! Michael