* [RFC PATCH 04/10] S390: smp: remove call to ipi_call_lock()/ipi_call_unlock()
[not found] <1338275765-3217-1-git-send-email-yong.zhang0@gmail.com>
@ 2012-05-29 7:15 ` Yong Zhang
0 siblings, 0 replies; only message in thread
From: Yong Zhang @ 2012-05-29 7:15 UTC (permalink / raw)
To: linux-kernel
Cc: ralf, sshtylyov, david.daney, nikunj, paulmck, axboe, mingo, tglx,
peterz, akpm, srivatsa.bhat, Martin Schwidefsky, Heiko Carstens,
linux390, linux-s390
From: Yong Zhang <yong.zhang@windriver.com>
1) call_function.lock used in smp_call_function_many() is just to protect
call_function.queue and &data->refs, cpu_online_mask is outside of the
lock. And it's not necessary to protect cpu_online_mask,
because data->cpumask is pre-calculate and even if a cpu is brougt up
when calling arch_send_call_function_ipi_mask(), it's harmless because
validation test in generic_smp_call_function_interrupt() will take care
of it.
2) For cpu down issue, stop_machine() will guarantee that no concurrent
smp_call_fuction() is processing.
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux390@de.ibm.com
Cc: linux-s390@vger.kernel.org
---
arch/s390/kernel/smp.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c
index 647ba94..14c8a08 100644
--- a/arch/s390/kernel/smp.c
+++ b/arch/s390/kernel/smp.c
@@ -716,9 +716,7 @@ static void __cpuinit smp_start_secondary(void *cpuvoid)
init_cpu_vtimer();
pfault_init();
notify_cpu_starting(smp_processor_id());
- ipi_call_lock();
set_cpu_online(smp_processor_id(), true);
- ipi_call_unlock();
local_irq_enable();
/* cpu_idle will call schedule for us */
cpu_idle();
--
1.7.5.4
^ permalink raw reply related [flat|nested] only message in thread