linux-s390.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	Carsten Otte <cotte@de.ibm.com>, Alexander Graf <agraf@suse.de>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	KVM <kvm@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>
Subject: [PATCH 3/6] KVM: s390: fix sigp sense running condition code handling
Date: Tue, 26 Jun 2012 16:06:38 +0200	[thread overview]
Message-ID: <1340719601-11867-4-git-send-email-cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1340719601-11867-1-git-send-email-cornelia.huck@de.ibm.com>

From: Heiko Carstens <heiko.carstens@de.ibm.com>

Only if the sensed cpu is not running a status is stored, which
is reflected by condition code 1. If the cpu is running, condition
code 0 should be returned.
Just the opposite of what the code is doing.

Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
 arch/s390/kvm/sigp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/s390/kvm/sigp.c b/arch/s390/kvm/sigp.c
index fda1d64..caccc0e 100644
--- a/arch/s390/kvm/sigp.c
+++ b/arch/s390/kvm/sigp.c
@@ -268,12 +268,12 @@ static int __sigp_sense_running(struct kvm_vcpu *vcpu, u16 cpu_addr,
 		if (atomic_read(fi->local_int[cpu_addr]->cpuflags)
 		    & CPUSTAT_RUNNING) {
 			/* running */
-			rc = 1;
+			rc = 0;
 		} else {
 			/* not running */
 			*reg &= 0xffffffff00000000UL;
 			*reg |= SIGP_STATUS_NOT_RUNNING;
-			rc = 0;
+			rc = 1;
 		}
 	}
 	spin_unlock(&fi->lock);
-- 
1.7.10.4

  parent reply	other threads:[~2012-06-26 14:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 14:06 [PATCH 0/6] kvm/s390: sigp related changes for 3.6 Cornelia Huck
2012-06-26 14:06 ` [PATCH 1/6] s390/smp: remove redundant check Cornelia Huck
2012-06-26 14:06 ` [PATCH 2/6] s390/smp/kvm: unifiy sigp definitions Cornelia Huck
2012-06-26 14:06 ` Cornelia Huck [this message]
2012-06-26 14:52   ` [PATCH 3/6] KVM: s390: fix sigp sense running condition code handling Alexander Graf
2012-06-26 15:33     ` Cornelia Huck
2012-06-26 15:36       ` Alexander Graf
2012-06-26 15:57         ` Cornelia Huck
2012-06-26 16:03           ` Alexander Graf
2012-06-26 14:06 ` [PATCH 4/6] KVM: s390: fix sigp set prefix status stored cases Cornelia Huck
2012-06-26 14:56   ` Alexander Graf
2012-06-26 15:39     ` Cornelia Huck
2012-06-26 15:42       ` Alexander Graf
2012-06-26 14:06 ` [PATCH 5/6] KVM: s390: use sigp condition code defines Cornelia Huck
2012-06-26 14:06 ` [PATCH 6/6] KVM: s390: Fix sigp sense handling Cornelia Huck
2012-06-29 23:19 ` [PATCH 0/6] kvm/s390: sigp related changes for 3.6 Marcelo Tosatti
2012-07-02 10:00   ` Martin Schwidefsky
2012-07-02 23:16 ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340719601-11867-4-git-send-email-cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=avi@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cotte@de.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).