Re: [PATCH v2 02/15] virtio: unify config_changed handling

Cornelia Huck
2014-10-06T15:16:14Z

On Mon, 6 Oct 2014 18:10:44 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> Replace duplicated code in all transports with a single wrapper in
> virtio.c.
>
> The only functional change is in virtio_mmio.c: if a buggy device sends
> us an interrupt before driver is set, we previously returned IRQ_NONE,
> now we return IRQ_HANDLED.
>
> As this must not happen in practice, this does not look like a big deal.
>
> See also commit 3fff0179e33cd7d0a688dab65700c46ad089e934
> virtio-pci: do not oops on config change if driver not loaded.
> for the original motivation behind the driver check.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/linux/virtio.h | 2 ++
> drivers/misc/mic/card/mic_virtio.c | 6 +-----
> drivers/s390/kvm/kvm_virtio.c | 9 +--------
> drivers/s390/kvm/virtio_ccw.c | 6 +-----
> drivers/virtio/virtio.c | 9 +++++++++
> drivers/virtio/virtio_mmio.c | 7 ++-----
> drivers/virtio/virtio_pci.c | 6 +-----
> 7 files changed, 17 insertions(+), 28 deletions(-)

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>