Re: [PATCH v8 17/50] KVM: s390: Set virtio-ccw transport revision

Cornelia Huck
2014-12-04T16:19:00Z

On Thu, 4 Dec 2014 18:10:22 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Dec 01, 2014 at 06:04:11PM +0200, Michael S. Tsirkin wrote:
> > From: Thomas Huth <thuth@linux.vnet.ibm.com>
> >
> > With the new SET-VIRTIO-REVISION command of the virtio 1.0 standard, we
> > can now negotiate the virtio-ccw revision after setting a channel online.
> >
> > Note that we don't negotiate version 1 yet.
> >
> > [Cornelia Huck: reworked revision loop a bit]
> > Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
> > Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
> > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Looking at this some more: to me it looks
> like this command should be repeated whenever we reset
> the device.
>
> No?

It should, when we re-setup.