From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1516667515.8378.24.camel@perches.com> Subject: Re: [PATCH v2] smc: return booleans instead of integers From: Joe Perches Date: Mon, 22 Jan 2018 16:31:55 -0800 In-Reply-To: References: <20180119205450.GA10785@embeddedgus> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Ursula Braun , "Gustavo A. R. Silva" , "David S. Miller" Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" List-ID: On Mon, 2018-01-22 at 12:58 +0100, Ursula Braun wrote: > > On 01/19/2018 09:54 PM, Gustavo A. R. Silva wrote: > > Return statements in functions returning bool should use > > true/false instead of 1/0. > > > > This issue was detected with the help of Coccinelle. > > > > Signed-off-by: Gustavo A. R. Silva > > --- > > Changes in v2: > > - Fix function using_ipsec as suggested by Ursula Braun. > > - Update subject line. > > > > net/smc/smc.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/net/smc/smc.h b/net/smc/smc.h [] > > @@ -253,12 +253,12 @@ static inline int smc_uncompress_bufsize(u8 compressed) > > static inline bool using_ipsec(struct smc_sock *smc) > > { > > return (smc->clcsock->sk->sk_policy[0] || > > - smc->clcsock->sk->sk_policy[1]) ? 1 : 0; > > + smc->clcsock->sk->sk_policy[1]) ? true : false; Generally, any bool return like return condition ? true : false; could be written return condition;