From: Jean Delvare <jdelvare@suse.de>
To: linux-s390@vger.kernel.org
Subject: Re: [PATCH 2/2] s390: qeth: Avoid unneeded command name lookup
Date: Wed, 12 Sep 2018 14:59:20 +0000 [thread overview]
Message-ID: <1536764360.18788.19.camel@suse.de> (raw)
In-Reply-To: <65861df5-afbe-e8b4-ea6e-37c12d6c2301@linux.ibm.com>
Hi Julian,
On Wed, 2018-09-12 at 16:50 +0200, Julian Wiedmann wrote:
> Thanks Jean, but I'd rather pass on this one. I don't see an improvement
> in readability, and performance just isn't a concern for this specific
> path... there's hardly any traffic on the interface's control plane.
Sure, you will know better. The initial optimization of
qeth_get_ipa_msg() and qeth_get_ipa_cmd_name() made me wonder if maybe
performance was considered important on these paths, and this is why I
wanted to pay attention that my changes would not cause a performance
regression. If there is no such concern then all is well and this
second patch is indeed not needed.
Thanks,
--
Jean Delvare
SUSE L3 Support
parent reply other threads:[~2018-09-12 14:59 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <65861df5-afbe-e8b4-ea6e-37c12d6c2301@linux.ibm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536764360.18788.19.camel@suse.de \
--to=jdelvare@suse.de \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).